Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a 1DFA command to allow SFX echo to match music that uses echo #137

Open
2 tasks
KungFuFurby opened this issue May 25, 2021 · 0 comments
Open
2 tasks

Add a 1DFA command to allow SFX echo to match music that uses echo #137

KungFuFurby opened this issue May 25, 2021 · 0 comments
Labels
enhancement New feature or request spc-side Involves the SPC700 code. vanilla-smw Involves a restoration that originates from vanilla SMW.

Comments

@KungFuFurby
Copy link
Owner

KungFuFurby commented May 25, 2021 •
edited
Loading

Requested by Anas on the SNESLab server.

This would cause the SFX to mirror the echo channels that are used by the music. This is disabled when SFX echo is forced off or on all channels if sent by another $1DFA command.

Interestingly, this replicates a vanilla SMW behavior where there was no real distinguishing between echo used for music and echo used for SFX: if the music has echo enabled on for the channel, then the same thing applies to the SFX.

  • Match SFX/Music Echo through UserDefines.asm (WARNING: Disables manually setting echo through $1DFA!)
  • Match SFX/Music Echo through $1DFA command
@KungFuFurby KungFuFurby added enhancement New feature or request spc-side Involves the SPC700 code. labels May 25, 2021
@KungFuFurby KungFuFurby added the vanilla-smw Involves a restoration that originates from vanilla SMW. label Jun 18, 2021
@KungFuFurby KungFuFurby mentioned this issue Jun 18, 2021
Open
KungFuFurby added a commit that referenced this issue Jun 20, 2021
@KungFuFurby
Add matching SFX echo channels to music echo channels by 1DFA command
fe812b1 
A new $1DFA command ID, $0A, has been added on for the purpose. Forcing all SFX
channels to have their echo off or on causes this to be disabled.

This commit mentions #137.
This was referenced Jun 20, 2021
Open
Merged
@KungFuFurby KungFuFurby mentioned this issue Apr 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request spc-side Involves the SPC700 code. vanilla-smw Involves a restoration that originates from vanilla SMW.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KungFuFurby