Add matching SFX echo channels to music echo channels by 1DFA command #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new $1DFA command ID, $0A, has been added on for the purpose. Forcing all SFX channels to have their echo off or on causes this to be disabled. This commit mentions #137.
Comes complete with a !noSFX section added on because of the merger of !noSFX into master combined with being removed from an enclosing !noSFX section.
Accidentally forgot to do so during merge conflict resolution
This section need not apply when SFX is not present.
Avoid accidental slowdown on jump and girder SFX caused by not doing this
…outine First of all, we don't want to accidentally execute ProcessAPU1SFX twice. Secondly, it's less memory efficient.
Shouldn't have gotten rid of that second endif...
This is being done because the branch goes directly to a RET in this case.
Accidentally removed the case to turn the carry off during a merge.
Partially cherry picked off of commit e026687 .
14 tasks
This prevents boolean-related confusion, and was also deprecated in asar 1.90.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new $1DFA command ID, $0A, has been added on for the purpose. Forcing all SFX
channels to have their echo off or on causes this to be disabled.
This commit mentions #137.