Skip to content

[PLT-1471] Remove pydantic v2 deprecate warnings #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: V6
merged 53 commits into from
Sep 25, 2024
Merged

[PLT-1471] Remove pydantic v2 deprecate warnings #1838

merged 53 commits into from
Sep 25, 2024

Conversation

@Gabefire
Copy link
Collaborator

@Gabefire Gabefire commented Sep 23, 2024 •
edited
Loading

Description

  • Removed pydantic warnings from SDK.
  • Removed datetime.utcnow from test which is also deprecated

vbrodsky and others added 30 commits September 16, 2024 18:05
@vbrodsky
Vb/fix ontology leaks plt 1379 (#1814)
0bbd7c2
@real-mjozwiak
[PTDT-2553] Added integration tests for MMC MAL/GT imports
51ecfea
@real-mjozwiak
[PTDT-2553] Added integration tests for MMC MAL/GT imports (#1795)
8d078c8
@vbrodsky
SDK release v.5.0.0 prep (#1823)
24e0766
@vbrodsky @Gabefire
Vb/merge 5.0.0 (#1826)
2faf9a1 
Co-authored-by: Gabe <33893811+Gabefire@users.noreply.github.com>
@vbrodsky
Revert "Vb/merge 5.0.0 (#1826)" (#1827)
2c0c677
@Gabefire
Removed data types besides generic data row data
c089215
@Gabefire
[PLT-1463] Removed ND deserialize from some unit test part 1 (#1804)
30819db
@Gabefire
[PLT-1463] Removed ND deserialize from some unit test part 2 (#1815)
761b1e9
@vbrodsky @Gabefire
[PLT-1274] Vb/deprecate bulkimportrequest plt 1274 (#1821)
379171a
@Gabefire
[PLT-1463] Remove deserialize completely (#1818)
5e87f4e
@Gabefire
[PLT-1488] Removed coco (#1820)
5fc6ff3
@Gabefire
Fixed video
9cf28a1
@Gabefire
Removed data type test
7fc10bb
@Gabefire
Merge branch 'solve_rebase_v6' into v6
8051d50
@Gabefire
Made fix
0b810fb
@Gabefire
Fix list of labels
f8b8fa3
@Gabefire
Merge branch 'v6' into gu/remove_data_types
556a5db
@Gabefire
Merge branch 'gu/remove_data_types' of github.com:Labelbox/labelbox-p…
aa551e1 
…ython into gu/remove_data_types
@Gabefire
Removed add url
2329324
@Gabefire
Removed rest of tests
4457f25
@Gabefire
Fix tests
f5b6c7d
@Gabefire
Finish PR
ce60b24
@Gabefire
Added back in tile data since some of its parameters are required
12aa8c5
@Gabefire
Merge branch 'v6' of github.com:Labelbox/labelbox-python into v6
f124e9d
@Gabefire
Removed data types besides generic data row data
b614ced
@Gabefire
Fixed video
e31d118
@Gabefire
Removed data type test
1a8189a
@Gabefire
Made fix
62f5fbd
@Gabefire
Fix list of labels
6c11e74
@Gabefire Gabefire requested a review from a team as a code owner September 23, 2024 23:05
@Gabefire Gabefire changed the base branch from develop to v6 September 23, 2024 23:06
Gabefire
Gabefire commented Sep 23, 2024
View reviewed changes
libs/labelbox/src/labelbox/data/annotation_types/types.py
@classmethod
def __get_validators__(cls):
yield cls.validate
def __get_pydantic_core_schema__(
Copy link
Collaborator Author

@Gabefire Gabefire Sep 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a story to simplify this class

Gabefire
Gabefire commented Sep 25, 2024
View reviewed changes
libs/labelbox/src/labelbox/schema/data_row_metadata.py
# Metadata schema
class DataRowMetadataSchema(BaseModel):
uid: SchemaId
name: str = Field(strip_whitespace=True, min_length=1, max_length=100)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strip_whitespace is depercated in pydantic V2 and gives warnings to users

vbrodsky
vbrodsky reviewed Sep 25, 2024
View reviewed changes
libs/labelbox/src/labelbox/schema/data_row_metadata.py
format_iso_from_string,
)

Name = Annotated[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

vbrodsky
vbrodsky approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@vbrodsky vbrodsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also remove some more warnings re
DeprecationWarning: datetime.datetime.utcnow()

Also can you squash these 53 commits?
Also can you add to the end of the epic to make sure we remove / do not have sdk deprecation warnings

@Gabefire Gabefire merged commit b6675f3 into v6 Sep 25, 2024
19 of 26 checks passed
@Gabefire Gabefire deleted the gu/cut_down_warnings branch September 25, 2024 17:00
vbrodsky pushed a commit that referenced this pull request Oct 11, 2024
@Gabefire
[PLT-1471] Remove pydantic v2 deprecate warnings (#1838)
e362281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vbrodsky vbrodsky vbrodsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gabefire @vbrodsky @real-mjozwiak