Merge develop into master (B2CA-1730) #88
Conversation
- Reconstruct the app based on the latest guidelines. - Make the code easier to test. - Make it easier to add new features.
…oroban Token plugin (#14)
…firming the transaction. (#61)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // for (uint8_t i = 0; i < 16; i++) { | ||
| // PRINTF("sub_invocation_positions[%d]=%d\n", | ||
| // i, | ||
| // envelope->soroban_authorization.sub_invocation_positions[i]); | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // static bool parse_fee_bump_transaction_ext(buffer_t *buffer) | ||
| // { | ||
| // uint32_t ext; | ||
| // PARSER_CHECK(parse_uint32(buffer, &ext)) | ||
| // if (ext != 0) | ||
| // { | ||
| // return false; | ||
| // } | ||
| // return true; | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // for (uint8_t i = 0; i < 16; i++) { | ||
| // PRINTF("sub_invocation_positions[%d]=%d\n", i, op->sub_invocation_positions[i]); | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // #ifdef HAVE_NBGL | ||
| // #include "nbgl_use_case.h" | ||
| // #endif |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // TODO: SDK bug, waiting for fix | ||
| // if (G_context.unverified_contracts) { | ||
| // op_type |= BLIND_OPERATION; | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
| switch (claimant->type) { | ||
| case CLAIMANT_TYPE_V0: | ||
| PARSER_CHECK(parse_account_id(buffer, &claimant->v0.destination)) | ||
| PARSER_CHECK(parse_claimant_predicate(buffer)) | ||
| return true; | ||
| default: | ||
| return false; | ||
| } |
Check notice
Code scanning / CodeQL
No trivial switch statements Note
| switch (liquidity_pool_type) { | ||
| case LIQUIDITY_POOL_CONSTANT_PRODUCT: { | ||
| PARSER_CHECK(parse_asset(buffer, &liquidity_pool_parameters->constant_product.asset_a)) | ||
| PARSER_CHECK(parse_asset(buffer, &liquidity_pool_parameters->constant_product.asset_b)) | ||
| PARSER_CHECK(parse_int32(buffer, &liquidity_pool_parameters->constant_product.fee)) | ||
| return true; | ||
| } | ||
| default: | ||
| return false; | ||
| } |
Check notice
Code scanning / CodeQL
No trivial switch statements Note
| #include "apdu/dispatcher.h" | ||
|
|
||
| // Global variables | ||
| swap_or_ui_t G; |
Check notice
Code scanning / CodeQL
Short global name Note
| return true; | ||
| } | ||
|
|
||
| static bool parse_operation(buffer_t *buffer, operation_t *operation) { |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
| return STELLAR_PLUGIN_RESULT_UNAVAILABLE; | ||
| } | ||
|
|
||
| stellar_plugin_result_t token_plugin_query_data_pair(const uint8_t *contract_address, |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
Wiz Scan Summary
|
No description provided.