Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto_device_count and device name support #13423

Merged
merged 94 commits into from
Jul 22, 2022
Merged

Add auto_device_count and device name support #13423

merged 94 commits into from
Jul 22, 2022

Conversation

jerome-habana
Copy link
Contributor

Signed-off-by: Jerome janand@habana.ai

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

jerome-habana and others added 3 commits June 28, 2022 06:03
@jerome-habana
Add auto_device_count and device name support
c0bc264 
Signed-off-by: Jerome <janand@habana.ai>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
24cbfc1 
for more information, see https://pre-commit.ci
@jerome-habana
Update change log
c103cff 
Signed-off-by: Jerome <janand@habana.ai>
@jerome-habana jerome-habana requested a review from kaushikb11 June 29, 2022 01:37
@jerome-habana
return default device count on failure
ca009a4 
Signed-off-by: Jerome <janand@habana.ai>
@jerome-habana @kaushikb11
Update src/pytorch_lightning/CHANGELOG.md
3c3fb0b 
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
@jerome-habana jerome-habana marked this pull request as ready for review June 29, 2022 10:09
@mergify mergify bot added the ready PRs ready to be merged label Jun 29, 2022
rohitgr7
rohitgr7 approved these changes Jun 29, 2022
View reviewed changes
src/pytorch_lightning/accelerators/hpu.py Outdated Show resolved Hide resolved
@Borda @rohitgr7 @justusschock
Apply suggestions from code review
b456564 
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
@kaushikb11 kaushikb11 added this to the pl:1.7 milestone Jun 30, 2022
@kaushikb11 kaushikb11 added the accelerator: hpu (external) Habana Processing Unit label Jun 30, 2022
@carmocca carmocca added the community This PR is from the community label Jun 30, 2022
@akihironitta akihironitta mentioned this pull request Jun 30, 2022
Closed
12 tasks
samz5320 and others added 8 commits July 14, 2022 04:56
@samz5320 @akihironitta
@carmocca @jerome-habana
Removed deprecated `pytorch_lightning.overrides.distributed.IndexBatc…
4239564 
…hSamplerWrapper.batch_indices` (Lightning-AI#13565)

* Removed the deprecated   method

* Removed deprecated  IndexBatchSamplerWrapper.batch_indices

* Update src/pytorch_lightning/CHANGELOG.md

* Missed code

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@CyprienRicque @rohitgr7 @jerome-habana
fix mypy typing errors in pytorch_lightning/strategies/dp.py (Lightni…
d83a423 
…ng-AI#13564)

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: otaj <ota@lightning.ai>
@awaelchli @jerome-habana
Remove deprecated Trainer.slurm_job_id (Lightning-AI#13459)
604f7ca
@akihironitta @carmocca @jerome-habana
Remove deprecated LightningModule.on_post_move_to_device (Lightning…
692da6a 
…-AI#13548)

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@awaelchli @akihironitta @jerome-habana
Remove deprecated ClustertEnvironment methods (Lightning-AI#13458)
8d8211e 
* Remove deprecated ClustertEnvironment methods

* update changelog

* ignore typing error

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
@carmocca @jerome-habana
Update CHANGELOG after the 1.6.5 release (Lightning-AI#13641)
db1e4d2
@akihironitta @carmocca @jerome-habana
Remove deprecated LightningDistributed (Lightning-AI#13549)
d825ada 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@jerome-habana
Merge branch 'master' into hpu_pkg
278f59a
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jul 14, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 20, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 20, 2022
kaushikb11 and others added 2 commits July 20, 2022 17:18
@codecov
Copy link

codecov bot commented Jul 20, 2022 •
edited
Loading

Codecov Report

Merging #13423 (ef634ff) into master (bc6d735) will decrease coverage by 6%.
The diff coverage is 39%.

@@            Coverage Diff             @@
##           master   #13423      +/-   ##
==========================================
- Coverage      82%      76%      -6%     
==========================================
  Files          93      327     +234     
  Lines        6102    25500   +19398     
==========================================
+ Hits         4996    19451   +14455     
- Misses       1106     6049    +4943

@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jul 20, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 21, 2022
@kaushikb11 kaushikb11 merged commit 9596fab into Lightning-AI:master Jul 22, 2022
@jerome-habana jerome-habana deleted the hpu_pkg branch July 22, 2022 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca left review comments

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@justusschock justusschock justusschock approved these changes

@Borda Borda Borda approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@awaelchli awaelchli Awaiting requested review from awaelchli

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@kaushikb11 kaushikb11

Labels
accelerator: hpu (external) Habana Processing Unit community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.7
Development

Successfully merging this pull request may close these issues.