Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Aug 17, 2022

What does this PR do?

After discussing with @edenlightning, we shall publish the stable version

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @rohitgr7 @carmocca @akihironitta

@Borda Borda added the docs Documentation related label Aug 17, 2022
@Borda Borda enabled auto-merge (squash) August 17, 2022 18:36
@mergify mergify bot added the ready PRs ready to be merged label Aug 17, 2022
@akihironitta akihironitta added ci Continuous Integration app (removed) Generic label for Lightning App package labels Aug 18, 2022
@akihironitta akihironitta added this to the app:0.5.x milestone Aug 18, 2022
@Borda Borda merged commit 52051c5 into master Aug 18, 2022
@Borda Borda deleted the cd/docs branch August 18, 2022 08:11
Borda added a commit that referenced this pull request Aug 19, 2022
(cherry picked from commit 52051c5)
This was referenced Aug 19, 2022
lantiga pushed a commit that referenced this pull request Aug 22, 2022
(cherry picked from commit 52051c5)
nicolai86 pushed a commit that referenced this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (removed) Generic label for Lightning App package ci Continuous Integration docs Documentation related ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants