-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Removes BYOC from LAI docs site #14297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Borda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove it when it is going to be added with the next release?
The content needs to be merged after/as the feature is available |
|
@Felonious-Spellfire We normally have the docs together with the feature development. The docs people see when going to our page are routing to |
The problem here is that App/LAI has only the latest docs till now... see the proposed changes in #14312 and #14250 |
|
Okay, that's fine with me. Hopefully this can change soon. It is really crucial that new features get reviewed and tested together with the docs present. |
What does this PR do?
Removes BYOC content from LAI site
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @rohitgr7