Skip to content

draft App 0.5.7 #14312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 22, 2022
Merged

draft App 0.5.7 #14312

merged 5 commits into from
Aug 22, 2022

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Aug 19, 2022 •
edited by github-actions bot
Loading

What does this PR do?

porting (#14250)
(cherry picked from commit 52051c5)

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @rohitgr7 @tchaton

@Borda
release LAI docs as stable (#14250)
df2c5a4 
(cherry picked from commit 52051c5)
@Borda Borda added the docs Documentation related label Aug 19, 2022
@Borda Borda mentioned this pull request Aug 19, 2022
Closed
12 tasks
@Borda Borda changed the title release LAI docs as stable draft App 0.5.7 Aug 21, 2022
@Borda Borda self-assigned this Aug 21, 2022
@Borda Borda marked this pull request as draft August 21, 2022 20:05
carmocca and others added 3 commits August 22, 2022 09:08
@carmocca @Borda
Update mising CODEOWNERS for the PL package (#14280)
5feadb7 
* Update CODEOWNERS

* Update .github/CODEOWNERS

(cherry picked from commit f7ac570)
@carmocca @Borda
Adjust mergify's number of reviewer rules (#14293)
6815491 
(cherry picked from commit 8662ab2)
@Borda
Pinning starsessions to 1.x (#14333)
f4bf8ff 
The recent release of starsessions 2.0 has broken lightning app as some of the arguments are removed. This PR also fixes a bug in our setup tools that prevents our internal # strict parameter being considered.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

(cherry picked from commit 52a4457)
@Borda Borda marked this pull request as ready for review August 22, 2022 07:18
@mergify mergify bot added the ready PRs ready to be merged label Aug 22, 2022
@Borda Borda added this to the app:0.5.x milestone Aug 22, 2022
@Borda Borda added priority: 0 High priority task release labels Aug 22, 2022
@lantiga lantiga merged commit 0ba4cbe into release/app Aug 22, 2022
@lantiga lantiga deleted the devel/app branch August 22, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lantiga lantiga lantiga approved these changes

@justusschock justusschock justusschock approved these changes

@carmocca carmocca Awaiting requested review from carmocca

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@Felonious-Spellfire Felonious-Spellfire Awaiting requested review from Felonious-Spellfire

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

+3 more reviewers

@manskx manskx manskx approved these changes

@hhsecond hhsecond hhsecond approved these changes

@akihironitta akihironitta akihironitta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Borda Borda

Labels

docs Documentation related priority: 0 High priority task ready PRs ready to be merged release

Projects

No open projects
Frameworks Planning
Status: Done

Milestone

app:0.5.x

Development

Successfully merging this pull request may close these issues.

7 participants

@Borda @lantiga @manskx @justusschock @hhsecond @akihironitta @carmocca