Skip to content

fix: Checkout and Git LFS fetch issue for pytorch docs workflow #21219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 15, 2025
Merged

fix: Checkout and Git LFS fetch issue for pytorch docs workflow #21219

merged 12 commits into from
Sep 15, 2025

Conversation

@bhimrazy
Copy link
Collaborator

@bhimrazy bhimrazy commented Sep 15, 2025 •
edited
Loading

What does this PR do?

Fixes checkout issue for pytorch docs-make workflow. : https://github.com/Lightning-AI/pytorch-lightning/actions/runs/17685529175/job/50269389074

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21219.org.readthedocs.build/en/21219/

@github-actions github-actions bot added docs Documentation related ci Continuous Integration labels Sep 15, 2025
@bhimrazy bhimrazy marked this pull request as draft September 15, 2025 11:57
Borda
Borda reviewed Sep 15, 2025
View reviewed changes
Copy link
Collaborator

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we would need to run this multiple times over a few days to validate it is fine as my test PR was also passing for a few days and after close-re-open it start failing the same way

@bhimrazy
Copy link
Collaborator Author

bhimrazy commented Sep 15, 2025

we would need to run this multiple times over a few days to validate it is fine as my test PR was also passing for a few days and after close-re-open it start failing the same way

Sure @Borda.
It seemed like there were issues in resolving the correct repo URLs between lightning-tutorials.git & tutorials.git.

@bhimrazy bhimrazy changed the title (test) Fix Git LFS authentication for docs workflow fix: Checkout and Git LFS fetch issue for pytorch docs workflow Sep 15, 2025
@bhimrazy bhimrazy marked this pull request as ready for review September 15, 2025 12:39
@Borda Borda merged commit bfb15b7 into Lightning-AI:master Sep 15, 2025
22 checks passed
justusschock pushed a commit that referenced this pull request Nov 5, 2025
@bhimrazy @justusschock
fix: Checkout and Git LFS fetch issue for pytorch docs workflow (#21219)
0e4e69b
justusschock added a commit that referenced this pull request Nov 5, 2025
@justusschock @bhimrazy
@matsumotosan @Borda @deependujha @SkafteNicki @williamFalcon
Release 2.5.6 (#21336)
5b3bb74 
* Remove Support For Deprecated Habana (#21327)

* remove habana

* changelog

* remove from install

* update docs

* update

* update

* pytest match

* Add name to accelerator interface (#21325)

* changelog + rebase

* version.info bumo

* fix: Checkout and Git LFS fetch issue for pytorch docs workflow (#21219)

* ci: `uv` for `docs-build` (#21206)

replace pip with uv

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

* fix: failing ci linkcheck in markdown (#21222)

Update timeout and retry configuration
Increased timeout and adjusted retry settings.

* simplify lit CI config (#21220)

* simplify lit CI config

* Empty-Commit

* Empty-Commit

* Update

---------

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>

* fix:docs build errors (#21286)

* docs: add 'typing.Union' to nitpick_ignore_regex in Sphinx configuration

* docs: add Supermicro link to linkcheck_ignore due to 403 error

* [Hotfix] Remove reference to `torch.jit.export` (#21292)

update docs

* Docs: drop deprecated project (#21250)

* drop dumping wheels after UV switch (#21217)

* chore(`ci/litjob`): fix and optimize GPU related tests (#21290)

* fix: add unzip to dependencies in pytorch workflow
* fix: update variable interpolation for PACKAGE_NAME in YAML workflows
* fix: update variable interpolation for PACKAGE_NAME in fabric workflow
* fix: disable CUDA_LAUNCH_BLOCKING to speed up tests
* apply suggestion

* remove integrations from Dockerfile

* Update readme (#21263)

Update LitServe description for clarity

* Update heading from 'Why PyTorch Lightning?' to 'Convert from PyTorch to PyTorch Lightning?'

* Fix heading formatting in README.md

* Add UTM parameters to links in README

Updated links in README to include UTM parameters for tracking.

* readme

readme

* readme updates

readme updates

* update readme

Update readme

* update

* update

* update

* update

* resolve docker builds

* update

* update

* update

* update

* update

* update

* update

---------

Co-authored-by: Bhimraj Yadav <bhimrajyadav977@gmail.com>
Co-authored-by: Shion Matsumoto <smatsumoto97@gmail.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Deependu <deependujha21@gmail.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: William Falcon <waf2107@columbia.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees

No one assigned

Labels

ci Continuous Integration docs Documentation related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bhimrazy @Borda