-
Notifications
You must be signed in to change notification settings - Fork 3.6k
chore(ci/litjob): fix and optimize GPU related tests
#21290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
It seems the delay in those tests is caused by Test Code
export CUDA_LAUNCH_BLOCKING=0
time python -c "
import torch
from lightning.pytorch.demos.boring_classes import BoringModel
model = BoringModel()
model.example_input_array = torch.randn((4, 32))
model.cuda()
print('Starting compilation with CI env vars...')
import time
start = time.time()
ret = model.to_tensorrt(ir='ts')
end = time.time()
print(f'Compilation took {end - start:.2f} seconds')
"
|
bhimrazy
commented
Nov 4, 2025
ci/litjob): fix and optimize GPU related tests
Borda
approved these changes
Nov 5, 2025
justusschock
pushed a commit
that referenced
this pull request
Nov 5, 2025
* fix: add unzip to dependencies in pytorch workflow * fix: update variable interpolation for PACKAGE_NAME in YAML workflows * fix: update variable interpolation for PACKAGE_NAME in fabric workflow * fix: disable CUDA_LAUNCH_BLOCKING to speed up tests * apply suggestion
justusschock
pushed a commit
that referenced
this pull request
Nov 5, 2025
* fix: add unzip to dependencies in pytorch workflow * fix: update variable interpolation for PACKAGE_NAME in YAML workflows * fix: update variable interpolation for PACKAGE_NAME in fabric workflow * fix: disable CUDA_LAUNCH_BLOCKING to speed up tests * apply suggestion
justusschock
added a commit
that referenced
this pull request
Nov 5, 2025
* Remove Support For Deprecated Habana (#21327) * remove habana * changelog * remove from install * update docs * update * update * pytest match * Add name to accelerator interface (#21325) * changelog + rebase * version.info bumo * fix: Checkout and Git LFS fetch issue for pytorch docs workflow (#21219) * ci: `uv` for `docs-build` (#21206) replace pip with uv Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> * fix: failing ci linkcheck in markdown (#21222) Update timeout and retry configuration Increased timeout and adjusted retry settings. * simplify lit CI config (#21220) * simplify lit CI config * Empty-Commit * Empty-Commit * Update --------- Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com> * fix:docs build errors (#21286) * docs: add 'typing.Union' to nitpick_ignore_regex in Sphinx configuration * docs: add Supermicro link to linkcheck_ignore due to 403 error * [Hotfix] Remove reference to `torch.jit.export` (#21292) update docs * Docs: drop deprecated project (#21250) * drop dumping wheels after UV switch (#21217) * chore(`ci/litjob`): fix and optimize GPU related tests (#21290) * fix: add unzip to dependencies in pytorch workflow * fix: update variable interpolation for PACKAGE_NAME in YAML workflows * fix: update variable interpolation for PACKAGE_NAME in fabric workflow * fix: disable CUDA_LAUNCH_BLOCKING to speed up tests * apply suggestion * remove integrations from Dockerfile * Update readme (#21263) Update LitServe description for clarity * Update heading from 'Why PyTorch Lightning?' to 'Convert from PyTorch to PyTorch Lightning?' * Fix heading formatting in README.md * Add UTM parameters to links in README Updated links in README to include UTM parameters for tracking. * readme readme * readme updates readme updates * update readme Update readme * update * update * update * update * resolve docker builds * update * update * update * update * update * update * update --------- Co-authored-by: Bhimraj Yadav <bhimrajyadav977@gmail.com> Co-authored-by: Shion Matsumoto <smatsumoto97@gmail.com> Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: Deependu <deependujha21@gmail.com> Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com> Co-authored-by: William Falcon <waf2107@columbia.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR has the following changes:
Reduced GPU test time by approximately 25–30 minutes.
Two of these tests were taking more than 20 minutes but, when run manually, finished within 5 seconds.
The delay in those tests was mainly caused by
CUDA_LAUNCH_BLOCKING=1.Before:


After:
Fixes a typo by replacing
$(PACKAGE_NAME)with${PACKAGE_NAME}.Fix:
unzipnot found — used in cipytorch-lightning/.actions/pull_legacy_checkpoints.sh
Line 10 in 573828a
Note: It seems there are still
ci/litjobfailures caused by port issues, which require a rerun to pass.PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist