Skip to content

Conversation

@justusschock
Copy link
Member

@justusschock justusschock commented Nov 3, 2025

What does this PR do?

Removes support for the already archived lightning-habana package as this makes it impossible to do changes like #21325

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21327.org.readthedocs.build/en/21327/

@github-actions github-actions bot added docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Nov 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml, src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/types.py, src/lightning/pytorch/_graveyard/hpu.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/trainer/setup.py, src/lightning/pytorch/utilities/imports.py, tests/tests_pytorch/graveyard/test_hpu.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py.

🟢 pytorch_lightning: lit GPU
Check ID Status
pytorch.yml / Lit Job (nvidia/cuda:12.1.1-devel-ubuntu22.04, pytorch, 3.10) success
pytorch.yml / Lit Job (lightning, 3.12) success
pytorch.yml / Lit Job (pytorch, 3.12) success

These checks are required after the changes to src/lightning/pytorch/_graveyard/hpu.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/trainer/setup.py, src/lightning/pytorch/utilities/imports.py, tests/tests_pytorch/graveyard/test_hpu.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/types.py.

🟢 Benchmarks
Check ID Status
benchmark.yml / Lit Job (fabric) success
benchmark.yml / Lit Job (pytorch) success

These checks are required after the changes to src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/types.py, src/lightning/pytorch/_graveyard/hpu.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/trainer/setup.py, src/lightning/pytorch/utilities/imports.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/types.py.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to src/lightning/pytorch/_graveyard/hpu.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/trainer/setup.py, src/lightning/pytorch/utilities/imports.py, docs/source-pytorch/common/index.rst, docs/source-pytorch/common_usecases.rst, docs/source-pytorch/conf.py, docs/source-pytorch/expertise_levels.rst, docs/source-pytorch/extensions/accelerator.rst, docs/source-pytorch/extensions/strategy.rst, docs/source-pytorch/glossary/index.rst, docs/source-pytorch/integrations/hpu/index.rst, docs/source-pytorch/levels/advanced.rst, docs/source-pytorch/levels/advanced_level_19.rst, docs/source-pytorch/levels/advanced_level_20.rst, docs/source-pytorch/levels/advanced_level_21.rst.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu-guardian success

These checks are required after the changes to src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/types.py.

🟢 lightning_fabric: lit GPU
Check ID Status
fabric.yml / Lit Job (nvidia/cuda:12.1.1-devel-ubuntu22.04, fabric, 3.10) success
fabric.yml / Lit Job (fabric, 3.12) success
fabric.yml / Lit Job (lightning, 3.12) success

These checks are required after the changes to src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/types.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to requirements/_integrations/accelerators.txt, src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/types.py, src/lightning/pytorch/_graveyard/hpu.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/trainer/setup.py, src/lightning/pytorch/utilities/imports.py.

🟢 install
Check ID Status
install-pkg-guardian success

These checks are required after the changes to src/lightning/fabric/utilities/distributed.py, src/lightning/fabric/utilities/types.py, src/lightning/pytorch/_graveyard/hpu.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/trainer/setup.py, src/lightning/pytorch/utilities/imports.py, requirements/_integrations/accelerators.txt.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 70 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87%. Comparing base (a883890) to head (2e54990).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #21327    +/-   ##
========================================
- Coverage      87%      87%    -1%     
========================================
  Files         270      270            
  Lines       23822    23764    -58     
========================================
- Hits        20795    20594   -201     
- Misses       3027     3170   +143     

@github-actions github-actions bot added the ci Continuous Integration label Nov 3, 2025
@justusschock justusschock merged commit 739cf13 into master Nov 3, 2025
112 of 113 checks passed
@justusschock justusschock deleted the remove_habana branch November 3, 2025 17:11
justusschock added a commit that referenced this pull request Nov 5, 2025
* remove habana

* changelog

* remove from install

* update docs

* update

* update

* pytest match
@justusschock justusschock mentioned this pull request Nov 5, 2025
justusschock added a commit that referenced this pull request Nov 5, 2025
* Remove Support For Deprecated Habana (#21327)

* remove habana

* changelog

* remove from install

* update docs

* update

* update

* pytest match

* Add name to accelerator interface (#21325)

* changelog + rebase

* version.info bumo

* fix: Checkout and Git LFS fetch issue for pytorch docs workflow (#21219)

* ci: `uv` for `docs-build` (#21206)

replace pip with uv

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

* fix: failing ci linkcheck in markdown (#21222)

Update timeout and retry configuration
Increased timeout and adjusted retry settings.

* simplify lit CI config (#21220)

* simplify lit CI config

* Empty-Commit

* Empty-Commit

* Update

---------

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>

* fix:docs build errors (#21286)

* docs: add 'typing.Union' to nitpick_ignore_regex in Sphinx configuration

* docs: add Supermicro link to linkcheck_ignore due to 403 error

* [Hotfix] Remove reference to `torch.jit.export` (#21292)

update docs

* Docs: drop deprecated project (#21250)

* drop dumping wheels after UV switch (#21217)

* chore(`ci/litjob`): fix and optimize GPU related tests (#21290)

* fix: add unzip to dependencies in pytorch workflow
* fix: update variable interpolation for PACKAGE_NAME in YAML workflows
* fix: update variable interpolation for PACKAGE_NAME in fabric workflow
* fix: disable CUDA_LAUNCH_BLOCKING to speed up tests
* apply suggestion

* remove integrations from Dockerfile

* Update readme (#21263)

Update LitServe description for clarity

* Update heading from 'Why PyTorch Lightning?' to 'Convert from PyTorch to PyTorch Lightning?'

* Fix heading formatting in README.md

* Add UTM parameters to links in README

Updated links in README to include UTM parameters for tracking.

* readme

readme

* readme updates

readme updates

* update readme

Update readme

* update

* update

* update

* update

* resolve docker builds

* update

* update

* update

* update

* update

* update

* update

---------

Co-authored-by: Bhimraj Yadav <bhimrajyadav977@gmail.com>
Co-authored-by: Shion Matsumoto <smatsumoto97@gmail.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Deependu <deependujha21@gmail.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: William Falcon <waf2107@columbia.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration dependencies Pull requests that update a dependency file docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants