Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ltfs_ordered_copy: honor --keep-tree for single file copies #244

Conversation

softloft38p-michael
Copy link
Contributor

Summary of changes

This pull request includes following changes or fixes.

  • Add --keep-tree support for single file copies

Description

Single file copies did not honor the --keep-tree flag so would always end up in the destination folder regardless of tree depth of source. This changes makes it possible to copy a single file with the tree preserved. It reuses the same logic that is used for multi-file copies.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have confirmed my fix is effective or that my feature works

Copy link
Member

@piste-jp piste-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@piste-jp
Copy link
Member

piste-jp commented Feb 3, 2021

@softloft38p-michael ,

Thank you for your PR! It looks a good improvement.

@piste-jp piste-jp merged commit f2769f2 into LinearTapeFileSystem:master Feb 3, 2021
@softloft38p-michael softloft38p-michael deleted the single_file_keep_tree branch February 10, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants