Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle 0-byte file on tape in ltfs-ordered_copy #276

Merged
merged 3 commits into from
May 10, 2021
Merged

Handle 0-byte file on tape in ltfs-ordered_copy #276

merged 3 commits into from
May 10, 2021

Conversation

piste-jp
Copy link
Member

@piste-jp piste-jp commented May 6, 2021

Summary of changes

This pull request includes following changes or fixes.

Description

In Python3, ltfs_ordered_copy creates a back trace because of unhandled exception. The root cause is LTFS never returns starting block against 0-byte file.

Fixes #273

This PR includes following changes also.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have confirmed my fix is effective or that my feature works

Atsushi Abe added 3 commits May 6, 2021 18:31
Handle copy 0-byte file correctly
704c6a2 
In addition to handle 0-byte file, this change includes the fix when
only one file and `--keep-tree` is specified.
Fix the destination path for copying EAs
1a1a107
Modify .gitignore
e34957c
@piste-jp piste-jp linked an issue May 6, 2021 that may be closed by this pull request
ltfs_ordered_copy python3 #273
Closed
@piste-jp piste-jp merged commit b13427a into LinearTapeFileSystem:v2.4-stable May 10, 2021
@piste-jp piste-jp deleted the ordered_cpy branch May 10, 2021 01:00
piste-jp pushed a commit that referenced this pull request May 10, 2021
Handle 0-byte file on tape in ltfs-ordered_copy (#276)
0a51e3c 
* Handle copy 0-byte file correctly
* Fix the problem when only one file are specified as a source and `--keep-tree` is specified
* Fix the destination path for copying EAs
* Modify .gitignore
@piste-jp
Copy link
Member Author

Merged to master by cherry-pick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ltfs_ordered_copy python3
1 participant
@piste-jp