Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See issue #38
What does this implement/fix?
This fixes typos and bugs in modules related to finned vehicles. This includes the Control Allocator, Actuator Manager, and FinModel within UUV AUV Control Allocator, as well as the FinPlugin and FinROSPlugin within UUV Gazebo Plugins/UUV Gazebo ROS Plugins.
Change List
Additional Comments
I've tested this with our three fin vehicle in simulation, sending a command similar to this:
ros2 topic pub -r 10 /<ROBOT_NAME>/control_input uuv_auv_control_allocator/AUVCommand "{surge_speed: 2, command: {force: {x: 100, y: 0.0, z: 0.0}, torque: {x: 0.0, y: -1000.0, z: 0.0}}}"
This does indeed cause the vehicle to move forward and sets the fins correctly to induce a body torque.