unsubscribe buttons impl #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VadymLuchko
requested review from
AKalinich-Luxoft,
RomanReznichenkoLuxoft and
ychernysheva
ychernysheva
requested changes
Jul 6, 2021
...pplication_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/unsubscribe_button_request.cc
Outdated
Show resolved
Hide resolved
...pplication_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/unsubscribe_button_request.cc
Outdated
Show resolved
Hide resolved
...pplication_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/unsubscribe_button_request.cc
Outdated
Show resolved
Hide resolved
...plication_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/unsubscribe_button_response.cc
Outdated
Show resolved
Hide resolved
src/components/application_manager/include/application_manager/application_impl.h
Show resolved
Hide resolved
.../rpc_plugins/sdl_rpc_plugin/include/sdl_rpc_plugin/commands/hmi/unsubscribe_button_request.h
Outdated
Show resolved
Hide resolved
...rpc_plugins/sdl_rpc_plugin/include/sdl_rpc_plugin/commands/hmi/unsubscribe_button_response.h
Outdated
Show resolved
Hide resolved
...pplication_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/unsubscribe_button_request.cc
Outdated
Show resolved
Hide resolved
ychernysheva
reviewed
Jul 7, 2021
...ication_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/unsubscribe_button_request.cc
Outdated
Show resolved
Hide resolved
ychernysheva
reviewed
Jul 8, 2021
...pplication_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/unsubscribe_button_request.cc
Outdated
Show resolved
Hide resolved
VadymLuchko
force-pushed
the
impl/sdl_0192_unsubscribe_buttons
branch
from
2529ff7
to
b2e43a2
Compare
VadymLuchko
merged commit 4cf9954
into
feature/sdl_0192_button_subscription_response_from_hmi
AKalinich-Luxoft
pushed a commit
that referenced
this pull request
Aug 13, 2021
commit ce9fc44 Author: Andrii Kalinich <AKalinich@luxoft.com> Date: Thu Aug 5 18:50:33 2021 -0400 Update CUSTOM_BUTTON logic commit 237562b Author: Andrii Kalinich <AKalinich@luxoft.com> Date: Thu Aug 5 09:10:59 2021 -0400 fixup! Address Livio comments commit 1614294 Author: Andrii Kalinich <AKalinich@luxoft.com> Date: Wed Aug 4 17:17:17 2021 -0400 Address Livio comments commit daa1060 Author: Andrii Kalinich <AKalinich@luxoft.com> Date: Tue Jul 27 20:15:06 2021 -0400 Address Livio comments commit a327f06 Author: Olha Vorobiova <olha.vorobiova@dxc.com> Date: Tue Jul 20 16:40:27 2021 +0300 Add unit tests for subscribe and unsubscribe button commit dce94e5 Merge: f78f0c8 82703c9 Author: Andrii Kalinich (GitHub) <AKalinich@luxoft.com> Date: Fri Jul 16 19:12:45 2021 -0400 Merge pull request #206 from LuxoftSDL/impl/sdl_0192_fix_resumption_of_button_subscriptions Separate subscription processing logic for mobile requests and resumption commit 82703c9 Author: Andrii Kalinich <AKalinich@luxoft.com> Date: Fri Jul 16 15:07:15 2021 -0400 Return on_event() back to HMI subscription request commit f78f0c8 Merge: 94c770b e7e1ebf Author: Andrii Kalinich (GitHub) <AKalinich@luxoft.com> Date: Fri Jul 16 19:00:15 2021 -0400 Merge pull request #205 from LuxoftSDL/fix/sdl_0192_fix_custom_button_subscription_logic Fix CUSTOM_BUTTON subscription logic commit e7e1ebf Author: Andrii Kalinich <AKalinich@luxoft.com> Date: Fri Jul 16 13:02:46 2021 -0400 Fix affected unit tests commit d156a9f Author: Yana Chernysheva <ychernysheva@luxoft.com> Date: Fri Jul 16 16:09:27 2021 +0300 Separate subscription processing for mobile requests and resumption commit 9e461d0 Author: Andrii Kalinich <AKalinich@luxoft.com> Date: Fri Jul 16 01:31:05 2021 -0400 Fix CUSTOM_BUTTON subscription logic Was removed subscription to custom button by default. Also, added check if app is actually subscribed to CUSTOM_BUTTON like for all other buttons. commit 94c770b Author: Yana Chernysheva <ychernysheva@luxoft.com> Date: Wed Jul 14 15:32:40 2021 +0300 Revert expired button requests if response was received after timeout commit de6c7aa Merge: 0343ea4 eaec9b4 Author: Yana Chernysheva <ychernysheva@luxoft.com> Date: Thu Jul 15 15:23:10 2021 +0300 Merge branch 'develop' into feature/sdl_0192_button_subscription_response_from_hmi commit 0343ea4 Author: Yana Chernysheva <ychernysheva@luxoft.com> Date: Mon Jul 5 14:46:21 2021 +0300 Add shared base class for mobile button notifications commit 3d7d670 Author: Yana Chernysheva <ychernysheva@luxoft.com> Date: Fri Jul 9 16:13:21 2021 +0300 Unify approach to result codes processing commit e5dfa88 Author: Yana Chernysheva <ychernysheva@luxoft.com> Date: Thu Jul 8 11:40:13 2021 +0300 Remove OnButtonSubscription notification commit 06dc978 Author: Yana Chernysheva <ychernysheva@luxoft.com> Date: Wed Jul 7 13:39:12 2021 +0300 Resume button subscriptions commit 4cf9954 Author: Vadym Luchko (GitHub) <76956836+VadymLuchko@users.noreply.github.com> Date: Fri Jul 9 14:09:43 2021 +0300 unsubscribe buttons implementation (#197) commit 1304547 Author: Yana Chernysheva <ychernysheva@luxoft.com> Date: Wed Jun 30 17:16:30 2021 +0300 Add SubscribeButtonRequest and SubscribeButtonResponse classes
AKalinich-Luxoft
added a commit
that referenced
this pull request
Aug 19, 2021
…nk#3744) * Add SubscribeButtonRequest and SubscribeButtonResponse classes * unsubscribe buttons implementation (#197) * Resume button subscriptions * Remove OnButtonSubscription notification * Unify approach to result codes processing * Add shared base class for mobile button notifications * Revert expired button requests if response was received after timeout * Fix CUSTOM_BUTTON subscription logic Was removed subscription to custom button by default. Also, added check if app is actually subscribed to CUSTOM_BUTTON like for all other buttons. * Separate subscription processing for mobile requests and resumption * Fix affected unit tests * Return on_event() back to HMI subscription request * Add unit tests for subscribe and unsubscribe button * Avoid subscribe to custom button by default * Address Livio comments * Address Livio comments * fixup! Address Livio comments * Update CUSTOM_BUTTON logic * Fix tests after merge conflicts Co-authored-by: Yana Chernysheva <ychernysheva@luxoft.com> Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com> Co-authored-by: Olha Vorobiova <olha.vorobiova@dxc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[FORDTCN-12188]
This PR is [ready] for review.
Risk
This PR makes [no ] API changes.
Testing Plan
ATF test scripts, affected UTs are updated
Summary
Add HMI unsubscribe button request and response
CLA