Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pin black to avoid conflict with consumers #63

Closed
wants to merge 1 commit into from
Closed

Do not pin black to avoid conflict with consumers #63

wants to merge 1 commit into from

Conversation

jbraswell
Copy link
Contributor

This was forcing us to use an older version of black. Also, because black is still in pre-release, had to add allow_prereleases to Pipfile.

Alternatively, since the code is written to fallback to autopep8 if import black fails, we could just remove the dependency on black entirely.

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2021

Codecov Report

Merging #63 (42d7972) into master (2b66c23) will decrease coverage by 0.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   94.63%   93.95%   -0.68%     
==========================================
  Files          10       10              
  Lines         745      745              
==========================================
- Hits          705      700       -5     
- Misses         40       45       +5     
Impacted Files Coverage Δ
pipenv_setup/setup_updater.py 93.65% <0.00%> (-3.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b66c23...42d7972. Read the comment docs.

@jbraswell
Copy link
Contributor Author

Not sure codecov/project is claiming reduced coverage for pipenv_setup/setup_updater.py.

@bryant-finney
Copy link
Collaborator

This PR looks related to #75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants