improved fr.json#1750
improved fr.json#1750khaledmhirsi wants to merge 3 commits intoMail-0:stagingfrom khaledmhirsi:patch-1
Conversation
Reviewed the whole json with Grok and corrected some things manually. Made the wording consistent and more similar to existing apps: - instead of using "e-mail, email, mail, courrier, message", it's "courriel" when referring to an email. - instead of saying "les indésirables", made it "courrier indésirable" - added "en cours" when necessary
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
WalkthroughThe French localization file for the mail application is updated to enhance clarity, consistency, and fluency across UI strings. The changes standardize terminology, adjust pluralization, and refine phrasing throughout the interface, while maintaining the existing JSON schema and message keys. Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
apps/mail/messages/fr.json (2)
227-232: Simplify ‘favourites’ labelCurrent: « Avec étoile ».
Suggested: simply « Favoris » to match the other keys (star,unstar,addedToFavorites, etc.) and to avoid awkward phrasing.- "favourites": "Avec étoile", + "favourites": "Favoris",
560-563: Remove trailing space in “bulkStar” stringThere is an extra space at the end of the value.
- "bulkStar": "Marquage aux favoris en masse ", + "bulkStar": "Marquage aux favoris en masse",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/mail/messages/fr.json(19 hunks)
🧰 Additional context used
🧠 Learnings (1)
apps/mail/messages/fr.json (1)
Learnt from: yaraslau-klimuk
PR: Mail-0/Zero#604
File: apps/mail/locales/en.json:366-389
Timestamp: 2025-04-06T18:28:21.659Z
Learning: The translation file for the editor's menu bar already includes an "orderedList" key with the value "Ordered List" as part of PR #604.
🔇 Additional comments (1)
apps/mail/messages/fr.json (1)
318-321: Optional: gender agreement for count-zero case
"aucune réponse"is correct (feminine réponse) ‑ good catch; no change needed.
| "defaultEmailUpdated": "Adresse e-mail par défaut mise à jour", | ||
| "failedToUpdateGmailAlias": "Échec de la mise à jour de l'alias e-mail par défaut" | ||
| }, |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Replace residual “e-mail” with “courriel” for consistency
Several strings still read « e-mail », e.g.:
defaultEmailUpdated,failedToUpdateGmailAliasdefaultEmailAlias,selectDefaultEmail, etc.- “Signatures e-mail” section titles/descriptions
Since the PR goal is to standardise on courriel, update these remaining occurrences.
- "defaultEmailUpdated": "Adresse e-mail par défaut mise à jour",
+ "defaultEmailUpdated": "Adresse courriel par défaut mise à jour",Apply the same replacement to the other listed keys.
Also applies to: 451-453, 467-469, 490-508
🏁 Script executed:
#!/bin/bash
rg -n "e-mail" apps/mail/messages/fr.jsonLength of output: 1110
Replace all remaining “e-mail” with “courriel” in apps/mail/messages/fr.json
Example diff:
- "defaultEmailUpdated": "Adresse e-mail par défaut mise à jour",
+ "defaultEmailUpdated": "Adresse courriel par défaut mise à jour",Please apply the same replacement to these locations in apps/mail/messages/fr.json:
- Lines 309–310:
defaultEmailUpdatedfailedToUpdateGmailAlias
- Lines 450–452:
defaultEmailAliasselectDefaultEmaildefaultEmailDescription
- Lines 457–460:
title(“Connexions e-mail”)descriptiondisconnectTitledisconnectDescription
- Lines 466–467:
connectEmailconnectEmailDescription
- Lines 490–491:
title(“Signatures e-mail”)description
- Line 589:
invalidEmail
Ensure every “e-mail” becomes “courriel” (plural “courriels” where appropriate).
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "defaultEmailUpdated": "Adresse e-mail par défaut mise à jour", | |
| "failedToUpdateGmailAlias": "Échec de la mise à jour de l'alias e-mail par défaut" | |
| }, | |
| "defaultEmailUpdated": "Adresse courriel par défaut mise à jour", | |
| "failedToUpdateGmailAlias": "Échec de la mise à jour de l'alias e-mail par défaut" | |
| }, |
🤖 Prompt for AI Agents
In apps/mail/messages/fr.json at lines 309-311, 450-452, 457-460, 466-467,
490-491, and 589, replace all occurrences of "e-mail" with "courriel" and use
"courriels" for plural forms. Update the values for keys including
defaultEmailUpdated, failedToUpdateGmailAlias, defaultEmailAlias,
selectDefaultEmail, defaultEmailDescription, title ("Connexions e-mail"),
description, disconnectTitle, disconnectDescription, connectEmail,
connectEmailDescription, title ("Signatures e-mail"), description, and
invalidEmail accordingly to reflect this change.
| "movedToSpam": "Déplacé vers les courriers indésirables", | ||
| "movingToSpam": "Déplacement vers les courriers indésirables en cours...", | ||
| "deletingMail": "Suppression du courriel en cours...", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Standardise “courriel(s) indésirable(s)” across the file
The text alternates between « courriers indésirables » (lines 22-23, 402-403, 527-528, 542-543) and « courriels indésirables » (lines 55-56).
Stick to one form to avoid user-visible inconsistency. Given the PR objective explicitly favours courriel, align everything to courriel(s) indésirable(s).
Diff (sample for the first occurrences):
- "movedToSpam": "Déplacé vers les courriers indésirables",
- "movingToSpam": "Déplacement vers les courriers indésirables en cours...",
+ "movedToSpam": "Déplacé vers les courriels indésirables",
+ "movingToSpam": "Déplacement vers les courriels indésirables en cours...",Do the same for all remaining instances.
Also applies to: 54-58, 402-403, 527-528, 542-543
🏁 Script executed:
#!/bin/bash
# List all occurrences of “courriers” and “courriels” in the French messages file
rg -n '"courrier' apps/mail/messages/fr.jsonLength of output: 46
🏁 Script executed:
#!/bin/bash
# Locate the French translation file and list all occurrences of both variants
file=$(find . -type f -path '*/apps/mail/messages/fr.json' -print -quit)
echo "Inspecting: $file"
rg -n '"courriers indésirables"' "$file"
rg -n '"courriels indésirables"' "$file"Length of output: 322
🏁 Script executed:
#!/bin/bash
# Search for occurrences of courriers, courriels, and indésirables in the French messages file
rg -n courriers apps/mail/messages/fr.json
rg -n courriels apps/mail/messages/fr.json
rg -n indésirables apps/mail/messages/fr.jsonLength of output: 3890
Standardiser l’usage de « courriel(s) indésirable(s) » dans fr.json
Les occurrences de « courriers indésirables » alternent avec « courriels indésirables ». Pour cohérence (la PR privilégie « courriel »), remplacez toutes les instances de « courriers indésirables » par « courriels indésirables ».
Points à corriger (exemples de clés et lignes) :
- movedToSpam / movingToSpam (l. 22-23)
- deleteAllSpam / deletingAllSpam (l. 54-55)
- confirmDeleteSpam (l. 58)
- goToSpam (l. 83 et 542)
- moveToSpam (l. 220 et 333)
- spam (libellé du dossier, l. 402)
Diff d’exemple pour les premières lignes :
- "movedToSpam": "Déplacé vers les courriers indésirables",
- "movingToSpam": "Déplacement vers les courriers indésirables en cours...",
+ "movedToSpam": "Déplacé vers les courriels indésirables",
+ "movingToSpam": "Déplacement vers les courriels indésirables en cours...",Appliquez ce même remplacement partout dans apps/mail/messages/fr.json.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "movedToSpam": "Déplacé vers les courriers indésirables", | |
| "movingToSpam": "Déplacement vers les courriers indésirables en cours...", | |
| "deletingMail": "Suppression du courriel en cours...", | |
| "movedToSpam": "Déplacé vers les courriels indésirables", | |
| "movingToSpam": "Déplacement vers les courriels indésirables en cours...", | |
| "deletingMail": "Suppression du courriel en cours...", |
🤖 Prompt for AI Agents
In apps/mail/messages/fr.json from lines 22 to 542, replace all occurrences of
"courriers indésirables" with "courriels indésirables" to maintain consistency
with the preferred term "courriel" used throughout the file. This includes keys
such as movedToSpam, movingToSpam, deleteAllSpam, deletingAllSpam,
confirmDeleteSpam, goToSpam, moveToSpam, and the spam folder label. Perform a
global search and replace for the phrase to ensure uniform terminology.
There was a problem hiding this comment.
Coderabbit start speaking french lol
There was a problem hiding this comment.
@khaledmhirsi Haha, good catch! 😄
I switched to French in my previous comment because I was reviewing the French localization file (fr.json) and providing feedback about French terminology consistency. I was probably trying to be contextually appropriate since we were discussing French translations.
However, you're right to point that out - it's better to keep code review feedback in English for accessibility, even when reviewing localization files. That way everyone on the team can understand the feedback regardless of the target language being localized.
The substance of my feedback remains the same though: there's an inconsistency between "courriers indésirables" and "courriels indésirables" throughout the file that should be standardized to "courriels indésirables" to match the PR's objective of using "courriel" consistently.
🐰
/| /|
( ✌️ )
|(_)|
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
|
@maxprilutskiy is our i18n source of truth |
|
This PR has merge conflicts and has been open for more than 3 days. It will be automatically closed. Please resolve the conflicts and reopen the PR if you'd like to continue working on it. |
2 participants
Reviewed the whole json with Grok and corrected some things manually.
Description
Made the wording consistent and more similar to existing apps:
Type of Change
Please delete options that are not relevant.
Areas Affected
Please check all that apply:
Testing Done
Describe the tests you've done:
Security Considerations
For changes involving data or authentication:
Checklist
Additional Notes
It could be a great idea to have multiple versions of the same language. For example English in the US/UK/Australia is different.
For here specifically, the word spam in french is different between french (Canada) and french (France): "pourriel" != "courrier indésirable"
Screenshots/Recordings
Add screenshots or recordings here if applicable.
By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.
Summary by CodeRabbit