Skip to content

Comments

New Crowdin updates#525

Merged
hiheyhello123 merged 10 commits intostagingfrom
l10n_staging
Mar 27, 2025
Merged

New Crowdin updates#525
hiheyhello123 merged 10 commits intostagingfrom
l10n_staging

Conversation

@longgoneaccount
Copy link
Contributor

@longgoneaccount longgoneaccount commented Mar 26, 2025

Summary by CodeRabbit

  • Chores
    • Removed the “Favourites” category across various language localizations, streamlining the mail categorization options for a cleaner and more intuitive user interface.
    • Enhanced French translations for key mail actions (including marking messages as unread, replying, and forwarding) along with refined notification messages, ensuring a consistent and clearer experience for French-speaking users.

@vercel
Copy link

vercel bot commented Mar 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
0 🛑 Canceled (Inspect) Mar 26, 2025 10:44pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 26, 2025

Walkthrough

This pull request removes the "favourites" entry from the "mailCategories" section in multiple localization JSON files, reducing the number of available mail categories from five to four. Additionally, the French locale (fr.json) is updated with several translation changes, including updates for the keys in threadDisplay, settings, mail, and noLabelsAvailable.

Changes

File(s) Change Summary
apps/mail/locales/{ar, ca, de, es, hi, ja, ko, pl, pt}.json Removed the "favourites" entry from the "mailCategories" section.
apps/mail/locales/fr.json Removed the "favourites" entry and updated translations for threadDisplay ("Mark as Unread" → "Marquer comme non lu"), settings ("Settings saved" → "Paramètres enregistrés"), mail ("Reply All" → "Répondre à tous", "Forward" → "Transférer"), and noLabelsAvailable ("No labels available" → "Aucune étiquette disponible").

Possibly related PRs

  • Feature/add favourite #484: Introduces a new "favourites" category in the localization files, which directly contrasts with the removal in this PR.
  • New Crowdin updates #440: Updates the "mailCategories" in the German localization (de.json), sharing a common focus on the same category entry.

Suggested reviewers

  • MrgSub

Poem

I'm a rabbit coding through the night,
Hopping past "favourites" with all my might.
JSON fields now slim and bright,
French phrases dance in pure delight.
With each code change, my heart takes flight,
Celebrating fixes with a bunny's light! 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4c5bc02 and 05d268f.

📒 Files selected for processing (10)
  • apps/mail/locales/ar.json (1 hunks)
  • apps/mail/locales/ca.json (1 hunks)
  • apps/mail/locales/de.json (1 hunks)
  • apps/mail/locales/es.json (1 hunks)
  • apps/mail/locales/fr.json (4 hunks)
  • apps/mail/locales/hi.json (1 hunks)
  • apps/mail/locales/ja.json (1 hunks)
  • apps/mail/locales/ko.json (1 hunks)
  • apps/mail/locales/pl.json (1 hunks)
  • apps/mail/locales/pt.json (1 hunks)
🔇 Additional comments (13)
apps/mail/locales/ja.json (1)

76-83: Removed "favourites" from "mailCategories" in Japanese localization
The "mailCategories" now only lists "primary", "important", "personal", "updates", "promotions", and "social", which meets the PR objective. Please ensure that no part of the application still relies on the removed "favourites" key.

apps/mail/locales/ko.json (1)

76-83: Removal of "favourites" key in Korean localization
The key "favourites": "즐겨찾기" has been removed, and the "mailCategories" now include "social" (line 82 marked with changes) as the final entry. This is consistent with reducing the total categories from five to four. Verify that this change does not affect downstream code that may reference "favourites".

apps/mail/locales/hi.json (1)

76-83: Confirmed removal of "favourites" in Hindi localization
The "mailCategories" section has been updated so that after the keys "primary", "important", "personal", "updates", "promotions", the only remaining category is "social": "सोशल". This matches the new category count. Please double-check that there are no remaining references to the removed "favourites" key.

apps/mail/locales/pt.json (1)

76-83: "favourites" key removal verified in Portuguese localization
The update removes the "favourites": "Favoritos" entry, leaving a "mailCategories" object that now ends with "social": "Social". This change is consistent with the overall Crowdin update objective. Confirm that all consumers of these localization files have been updated accordingly.

apps/mail/locales/ca.json (1)

76-83: Catalan localization: "favourites" key successfully removed
The "mailCategories" object now only includes "primary", "important", "personal", "updates", "promotions", followed by "social": "Social". This deletion reduces the number of categories from five to four and is consistent with similar changes in other locale files. Please ensure that any application logic relying on the removed key is updated as well.

apps/mail/locales/pl.json (1)

76-83: Consistent Mail Categories Update in Polish Localization
The "favourites" entry has been removed from the "mailCategories" section, leaving the entries "primary", "important", "personal", "updates", "promotions", and "social" intact. This change aligns with the coordinated update across locales.

apps/mail/locales/ar.json (1)

76-83: Arabic Localization: Mail Categories Updated
The "favourites" key has been removed from the "mailCategories" section, ensuring that only the intended categories (including "social") remain. This update is consistent with the changes in other language files.

apps/mail/locales/de.json (1)

76-83: German Localization Update
The removed "favourites": "Favoriten" entry correctly reflects a reduction in mail categories. The remaining keys are now "primary", "important", "personal", "updates", "promotions", and "social", which meets the PR objectives.

apps/mail/locales/es.json (1)

76-83: Spanish Localization: Mail Categories Refinement
The "favourites" entry has been removed from the "mailCategories" section. The updated list—with "primary", "important", "personal", "updates", "promotions", and "social"—is consistent with the coordinated update across locales.

apps/mail/locales/fr.json (4)

76-83: French Mail Categories Update
The "favourites" entry has been removed from the "mailCategories" section, leaving the categories "primary", "important", "personal", "updates", "promotions", and "social". This is in line with the overall objective to reduce the number of mail categories.


114-123: Translation Update in Thread Display
Within the "threadDisplay" section, the translation for the key "markAsUnread" has been updated to "Marquer comme non lu". This update properly localizes the user interface in French. Please ensure downstream UI components interpret this change correctly.


188-193: French Settings Translation Improvement
The string for "saved" in the "settings" section is now translated as "Paramètres enregistrés". This effectively updates the localization for settings feedback messages in French.


219-223: Enhanced French Mail Section Translations
The following updates have been applied in the "mail" section:
"replyAll" is now "Répondre à tous"
"forward" is now "Transférer"
"noLabelsAvailable" is updated to "Aucune étiquette disponible"
These changes enhance the French localization and ensure a consistent user experience.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hiheyhello123 hiheyhello123 merged commit bdb80a0 into staging Mar 27, 2025
5 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jul 17, 2025
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants