Skip to content

Comments

chore: translate Japanese locale strings for mail actions and settings#530

Closed
dai wants to merge 1 commit intoMail-0:stagingfrom
dai:staging
Closed

chore: translate Japanese locale strings for mail actions and settings#530
dai wants to merge 1 commit intoMail-0:stagingfrom
dai:staging

Conversation

@dai
Copy link

@dai dai commented Mar 28, 2025

Description

Please provide a clear description of your changes.


Type of Change

Please delete options that are not relevant.

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature with breaking changes)
  • 📝 Documentation update
  • 🎨 UI/UX improvement
  • 🔒 Security enhancement
  • ⚡ Performance improvement

Areas Affected

Please check all that apply:

  • Email Integration (Gmail, IMAP, etc.)
  • User Interface/Experience
  • Authentication/Authorization
  • Data Storage/Management
  • API Endpoints
  • Documentation
  • Testing Infrastructure
  • Development Workflow
  • Deployment/Infrastructure

Testing Done

Describe the tests you've done:

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • Cross-browser testing (if UI changes)
  • Mobile responsiveness verified (if UI changes)

Security Considerations

For changes involving data or authentication:

  • No sensitive data is exposed
  • Authentication checks are in place
  • Input validation is implemented
  • Rate limiting is considered (if applicable)

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in complex areas
  • I have updated the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix/feature works
  • All tests pass locally
  • Any dependent changes are merged and published

Additional Notes

Hi, I'm japanese Translator at daisuke osada (barlog) .

I translated ja.json directly because crowdin was out of order.

Best.


By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

Summary by CodeRabbit

  • New Features
    • Enhanced Japanese translations across the app’s interface, including email management actions, note operations, color themes, and settings messages to provide a more intuitive experience for Japanese-speaking users.

@vercel
Copy link

vercel bot commented Mar 28, 2025

@dai is attempting to deploy a commit to the Zero Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 28, 2025

Walkthrough

The pull request updates the Japanese localization file (apps/mail/locales/ja.json). Various user interface strings related to email functionalities, note actions, color names, and settings messages have been translated from English into Japanese. The modifications include changes to keys such as "moveToSpam", "markAsUnread", "markAsRead", "favourites", note operations in the actions section, and several messages in the settings. No alterations to exported or public entities have been made.

Changes

File Change Summary
apps/mail/.../ja.json Updated Japanese translations for email actions (e.g., move to spam, mark as unread/read), note actions (pin, unpin, edit, delete, copy, change color), colors, and settings messages.

Possibly related PRs

Suggested reviewers

  • needleXO

Poem

I’m a rabbit in a code-filled glade,
Hopping through translations freshly laid.
From spam to notes, each string now sings,
In Japanese verses, the interface rings.
🐇 Celebrating change with joyful leaps and bounds!
Hop along and watch the magic abound.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0c48dd0 and c3e1231.

📒 Files selected for processing (1)
  • apps/mail/locales/ja.json (2 hunks)
🔇 Additional comments (5)
apps/mail/locales/ja.json (5)

119-126: Translation Consistency in Thread Display Section
The translations for the thread display actions (i.e., "moveToSpam", "markAsUnread", "markAsRead", and "favourites") appear correctly localized. Please double-check that these phrases maintain the same tone and terminology as used in other parts of the application.


175-177: Accurate Color Names in Notes Section
The Japanese equivalents for the color keys ("blue": "青", "purple": "紫", "pink": "ピンク") are correctly translated. Ensure that these match any branding or style guidelines used in the app.


180-185: Localized Note Actions
The updated translations for note-related actions (such as "pin", "unpin", "edit", "delete", "copy", and "changeColor") are clear and appropriate. Verify that the phrasing is consistent with similar UI commands elsewhere in the app.


189-192: Settings Messages Localization
The settings messages ("notFound", "saved", "failedToSave", and "languageChanged") have been translated into Japanese in a user-friendly manner. Please confirm that these translations provide clear guidance and error messaging consistent with the overall app experience.


196-223: Mail UI Translations Accuracy
The multiple UI strings in the mail section have been updated appropriately. All placeholders (e.g., {count}) remain intact, which is important for dynamic content rendering. Ensure that these translations effectively convey the intended actions (like selections, archiving, moving emails, etc.) and harmonize with other related sections of the UI.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hiheyhello123
Copy link
Contributor

The translations are supposed to be done through Crowdin...

You can upload the translated .json file if you don't want to bother with the Crowdin translate editor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants