Skip to content

Comments

New Crowdin updates#474

Merged
MrgSub merged 4 commits intostagingfrom
l10n_staging
Mar 18, 2025
Merged

New Crowdin updates#474
MrgSub merged 4 commits intostagingfrom
l10n_staging

Conversation

@longgoneaccount
Copy link
Contributor

@longgoneaccount longgoneaccount commented Mar 17, 2025

Summary by CodeRabbit

  • Localization Updates
    • French: Improved the unsubscribe option text for clearer user communication.
    • Korean: Removed outdated email interface strings to streamline localization.
    • Latvian: Refined translations for enhanced grammar and clarity in actions and statuses.
    • Russian: Updated various UI labels and action descriptions for better consistency and understanding.

@vercel
Copy link

vercel bot commented Mar 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
0 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 0:12am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 17, 2025

Walkthrough

This pull request updates several localization files for the Mail application. The French file now presents "Unsubscribe" as "Se désabonner." In the Korean file, the entire email localization section has been removed. The Latvian file receives corrections and improved phrasing for various UI strings, and the Russian file has multiple translation refinements across UI labels, descriptions, and commands. No changes were made to exported or public entity declarations.

Changes

File Change Summary
apps/.../fr.json Updated French translation: replaced "Unsubscribe" with "Se désabonner".
apps/.../ko.json Removed the entire "mail" section containing email-related strings.
apps/.../lv.json Corrected grammatical errors and updated several UI email strings (e.g., "Unsubscribe" to "Atrakstīties").
apps/.../ru.json Refined translations for multiple UI elements including action labels, palette commands, and navigation.

Possibly related PRs

  • i18n #437: Related to a new entry for "languageChangedTo" in the French localization file, which complements the update made in this PR.

Suggested reviewers

  • needleXO

Poem

I'm a bunny hopping through our code,
Leaping over strings in each abode.
French phrases now sing quite clear,
Latvian tweaks bring updates near.
Russian words now dance in delight,
And even Korean fades from sight!
Hoppy updates make our app feel bright!

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/mail/locales/ru.json (1)

50-60: Russian Search Bar Phrasing:
The updates in the search bar (e.g., "pickDateRange": "Выбрать дату или диапазон" and "quickFilters": "Быстрый фильтр") are mostly clear. Consider reviewing the phrasing for "dateRange": "Дата диапазона", as a native phrasing like "Диапазон дат" might sound more natural.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 737c0af and 67d3ee8.

📒 Files selected for processing (4)
  • apps/mail/locales/fr.json (1 hunks)
  • apps/mail/locales/ko.json (0 hunks)
  • apps/mail/locales/lv.json (5 hunks)
  • apps/mail/locales/ru.json (2 hunks)
💤 Files with no reviewable changes (1)
  • apps/mail/locales/ko.json
🔇 Additional comments (11)
apps/mail/locales/fr.json (1)

105-107: French "Unsubscribe" Translation Update:
The key "unsubscribe" has been correctly updated to "Se désabonner", which improves localization. However, note that related keys—such as "unsubscribed" and "unsubscribeDescription"—remain in English. Please verify whether these should also be translated to ensure a consistent French user experience.

apps/mail/locales/lv.json (2)

63-64: Latvian Status Labels Improvement:
The updates for "unread" (now "Nelasītie") and "hasAttachment" (now "Ir pielikums") enhance clarity and correctness for Latvian users.


127-156: Latvian Notes Section Consistency Check:
While many keys in the notes section have been translated (for example, "title": "Piezīmes" and "empty": "Šim e-pastam nav piezīmju"), several entries such as "noteUnpinned", "noteCount", and "notesReordered" still appear in English. Please confirm if these should be localized as well for full consistency.

apps/mail/locales/ru.json (8)

6-10: Russian Actions & Themes Update:
The updates for action-related keys (e.g., "create": "Создать Письмо" and "resetToDefaults": "Сбросить к значениям по умолчанию") along with the theme labels (e.g., "dark": "Тёмный", "light": "Светлый", "system": "Системный") are clear and contextually appropriate.


20-30: Russian Command Palette Enhancements:
The command palette section now features streamlined translations such as "title": "Команда" and "description": "Быстрый переход и действия для Mail-0", which improve clarity. Ensure these updates are consistent with similar changes in the other locale files.


95-111: Russian Mail Display Localization:
The translations in the mail display block—such as "unsubscribe": "Отменить подписку" and "unsubscribed": "Подписка отменена"—are comprehensible. However, please verify that the term "mailedBy": "Прописано" suits the intended context and is consistent with the application’s overall terminology.


127-157: Russian Notes Section Partial Translation:
While many keys in the notes section have been localized (e.g., "title": "Заметки", "empty": "Нет заметок в этом письме"), several error messages and count-related keys (such as "failedToLoadNotes" and "noteCount") remain in English. Please determine if full translation is desired for a uniform user experience.


187-208: Russian Mail Block Inconsistency:
The "mail" block still contains many English phrases (for example, in the pluralization patterns like "{count, plural, =0 {replies} one {# reply} other {# replies}}" and messages such as "Selected {count} emails"). If complete localization is intended, consider updating these strings.


212-220: Russian Navigation Sidebar Review:
The navigation sidebar entries (e.g., "inbox": "Входящие", "drafts": "Черновики", "sent": "Отправленные") are fully localized and consistent with user expectations.


230-237: Russian Pages and Error Messages:
The translations for the error pages and settings (e.g., "notFound" and "settingsNotFound") are well done and contribute to a better user experience.


308-314: Russian Email Creation Section:
The email creation section now clearly provides instructions to users with localized text such as "body": "Текст письма" and "writeYourMessageHere": "Напишите свое сообщение здесь...".

@MrgSub MrgSub merged commit 4e54aa9 into staging Mar 18, 2025
5 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Mar 18, 2025
This was referenced Apr 1, 2025
@coderabbitai coderabbitai bot mentioned this pull request Jul 17, 2025
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants