Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis pull request updates several localization JSON files within the mail application. In eight locales the diff adds two new entries, Changes
Possibly related PRs
Suggested reviewers
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (15)
apps/mail/locales/tr.json (1)
219-220: New Navigation Entries Added in Turkish Localization
The keys"feedback"and"contact"have been added to the sidebar section. Their values remain in English even though most other labels appear in Turkish. Confirm that this is the intended behavior (e.g. if these terms are meant to be left untranslated or will be updated later).apps/mail/locales/ca.json (1)
219-220: Catalan Localization – New Navigation Entries
The additions of"feedback": "Feedback"and"contact": "Contact"under the navigation (sidebar) section align with the Crowdin update. Please verify whether these values should remain in English or if they should be translated into Catalan for consistency with the rest of the locale.apps/mail/locales/ar.json (1)
219-220: Arabic Localization – New Sidebar Entries
The new entries"feedback": "Feedback"and"contact": "Contact"have been incorporated into the sidebar. Since the rest of the file is in English (or follows a specific style), please confirm if the use of these default English strings is acceptable or if localized Arabic equivalents should be provided.apps/mail/locales/ko.json (1)
219-220: Korean Localization – Verify Translation for New Keys
The keys"feedback"and"contact"have been added in the sidebar section. Note that even though the file is predominantly in Korean, these entries remain in English. Please confirm whether this is intentional or if updated Korean translations are required.apps/mail/locales/hi.json (1)
219-220: Hindi Localization – New Sidebar Entries Added
The new keys"feedback"and"contact"appear in the sidebar section with English values. Verify if these should be localized into Hindi according to our style guidelines, or if leaving them in English is the desired behavior.apps/mail/locales/de.json (1)
219-221: Review: Verify Navigation Entry Localization
The new entries"feedback": "Feedback"and"contact": "Contact"have been added in the sidebar. Please confirm that using the English terms is intentional for German users rather than using localized terms (e.g. "Kontakt" for "contact").apps/mail/locales/fr.json (1)
219-221: Review: Confirm Navigation Term Conventions
The"feedback"and"contact"keys have been added with values "Feedback" and "Contact". Verify with the localization guidelines whether these entries should remain in English or if French equivalents are preferred.apps/mail/locales/pl.json (1)
219-221: Review: Check Consistency of New Navigation Entries
The new entries"feedback": "Feedback"and"contact": "Contact"appear in the sidebar section. Please ensure that these values align with the established Polish localization conventions or if they should be translated.apps/mail/locales/ja.json (2)
105-111: Review: Validate Unsubscribe Section Translations
The unsubscribe-related keys in themailDisplaysection are translated (e.g."unsubscribe": "購読を解除"). It would be beneficial to double-check these phrasing choices with a Japanese language expert to ensure they accurately convey the intended meaning for unsubscribing from a mailing list.
219-221: Review: Verify Navigation Entry Localization
In the sidebar, the new entries"feedback": "Feedback"and"contact": "Contact"are still in English. Please confirm whether these should remain untranslated in Japanese or if localized equivalents are available.apps/mail/locales/ru.json (1)
219-221: Review: Confirm Navigation Terms in Russian Localization
The"feedback"and"contact"entries have been added with values "Feedback" and "Contact". Please confirm with the Russian translation guidelines if these keys are expected to remain in English or if they require translation.apps/mail/locales/es.json (1)
219-220: Navigation Entries Localization:
The new sidebar entries "feedback" and "contact" are still in English. Consider localizing these strings (for example, to "Comentarios" and "Contacto") to ensure full consistency with the Spanish locale.apps/mail/locales/lv.json (1)
219-220: Navigation Entries Localization:
The sidebar items "feedback" and "contact" are still in English. For a fully localized experience, consider converting them to Latvian (for example, "Atsauksmes" for feedback and "Kontakts" for contact).apps/mail/locales/pt.json (2)
201-201: Review 'archive' Translation:
The "archive" key is currently translated as "Arquivo." If this key is meant to indicate an action (i.e., to archive an email), using the verb "Arquivar" might be more appropriate. Please confirm the intended usage and adjust if needed.
219-220: Navigation Entries Localization:
The new navigation entries "feedback" and "contact" are in English. For proper localization, consider translating "contact" to "Contato" (and review "Feedback" if any adjustment is needed) so that these entries align with the rest of the Portuguese locale.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
apps/mail/locales/ar.json(1 hunks)apps/mail/locales/ca.json(1 hunks)apps/mail/locales/de.json(1 hunks)apps/mail/locales/es.json(3 hunks)apps/mail/locales/fr.json(1 hunks)apps/mail/locales/hi.json(1 hunks)apps/mail/locales/ja.json(3 hunks)apps/mail/locales/ko.json(1 hunks)apps/mail/locales/lv.json(8 hunks)apps/mail/locales/pl.json(1 hunks)apps/mail/locales/pt.json(3 hunks)apps/mail/locales/ru.json(2 hunks)apps/mail/locales/tr.json(1 hunks)
🔇 Additional comments (5)
apps/mail/locales/es.json (1)
105-111: Review Unsubscribe Translations:
The unsubscribe-related keys are translated clearly and consistently into Spanish. The phrases such as "Cancelar suscripción" and "Suscripción cancelada" convey the intended meaning accurately.apps/mail/locales/lv.json (3)
6-7: Update 'create' Action Translation:
The translation for the "create" key has been revised to "Rakstīt e-pastu," which provides a more action-oriented tone. Please verify that this aligns with the overall style guidelines.
40-41: New Email Translation Update:
The "newEmail" command now reads "Rakstīt jaunu e-pastu," which is clear and consistent. Confirm that this phrasing meshes well with similar commands across the application.
127-157: Notes Section Review:
The updates in the "notes" section provide comprehensive translations for note-related messages and actions. The ICU pluralization syntax (e.g., in "noteCount") appears consistent; please verify that it meets the application’s formatting requirements.apps/mail/locales/pt.json (1)
105-111: Portuguese Unsubscribe Translations:
The unsubscribe-related keys are well translated into Portuguese. The messages are clear, and the terminology (e.g., "Desinscrever", "Desinscrito") accurately reflects the intended actions.
| "moving": "Moving...", | ||
| "moved": "Moved", | ||
| "errorMoving": "Error moving" | ||
| "replies": "{count, plural, =0 {arquivos} one {arquivo} other {arquivos}}", |
There was a problem hiding this comment.
Incorrect Translation for 'replies':
The translation for "replies" currently uses "arquivo/arquivos," which appears to be a mix-up with file-related terms. It should likely read "respostas" instead.
Suggested diff:
- "replies": "{count, plural, =0 {arquivos} one {arquivo} other {arquivos}}",
+ "replies": "{count, plural, =0 {respostas} one {# resposta} other {# respostas}}",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "replies": "{count, plural, =0 {arquivos} one {arquivo} other {arquivos}}", | |
| "replies": "{count, plural, =0 {respostas} one {# resposta} other {# respostas}}", |
3 participants
Summary by CodeRabbit
New Features
Localization Updates