Added hover opacity on nav-user for better visibility#753
Closed
Adarsh9977 wants to merge 47 commits intoMail-0:mainfrom
Closed
Added hover opacity on nav-user for better visibility#753Adarsh9977 wants to merge 47 commits intoMail-0:mainfrom
Adarsh9977 wants to merge 47 commits intoMail-0:mainfrom
Conversation
- added cc and bcc when saving drafts - save drafts less aggresively
chore: simplify and fix the dev env
* Create prompts with XML formatting * Include XML formatted prompts in generate func * remove unused regex and add helper functions/warnings * error handling * Update apps/mail/lib/prompts.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * lint issues * Update prompts.ts * Mail-0#706 (comment) Coderabbit fix 1 * erabbitai bot 3 days ago⚠️ Potential issue errorOccurred state is stale inside finally React state setters (setErrorOccurred) are asynchronous; the errorOccurred value captured at render time will not yet reflect changes made earlier in the same event loop. Consequently, the logic deciding whether to collapse/expand may run with an outdated flag. - } finally { - setIsLoading(false); - if (!errorOccurred || isAskingQuestion) { - setIsExpanded(true); - } else { - setIsExpanded(false); // Collapse on errors - } - } + } finally { + setIsLoading(false); + // Use a local flag to track errors deterministically + const hadError = isAskingQuestion ? false : !!errorFlagRef.current; + setIsExpanded(!hadError); + } You can create const errorFlagRef = useRef(false); and update errorFlagRef.current = true every time an error is detected, ensuring reliable behaviour irrespective of React batching. Committable suggestion skipped: line range outside the PR's diff. * Mail-0#706 (comment) * Mail-0#706 (comment) * Mail-0#706 (comment) --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…users (Mail-0#726) * feat(i18n): add Vietnamese language support Add Vietnamese ('vi') to the list of supported languages in the i18n configuration and JSON file to expand language options. * Add a new Vietnamese translation file to support Vietnamese language users. * Clear Vietnamese translation strings
Co-authored-by: needle <122770437+needleXO@users.noreply.github.com>
* Updated lockfile * Updated home page session validation --------- Co-authored-by: Adam <x_1337@outlook.com>
* Create route og image * resolve coderabbit nitpicks --------- Co-authored-by: Adam <x_1337@outlook.com>
|
@Adarsh9977 is attempting to deploy a commit to the Zero Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Caution Review failedThe pull request is closed. ## Walkthrough
This update standardizes the opacity styling for interactive UI elements in the mail application's connection and navigation user components. Opacity and hover effects are now applied at the container or button level, rather than on individual icons or text within those elements. No changes have been made to the logic, exported entities, or control flow; the modifications are purely visual and focused on CSS class management for a more consistent appearance and hover behavior.
## Changes
| File(s) | Change Summary |
|-----------------------------------------------------|------------------------------------------------------------------------------------------------------------------|
| apps/mail/components/connection/add.tsx | Moved opacity and hover opacity classes to the button element; removed individual opacity styling from icon/text. |
| apps/mail/components/ui/nav-user.tsx | Applied opacity and hover opacity classes to menu item containers; removed opacity styling from icons/text. |
## Possibly related PRs
- Mail-0/Zero#424: Adjusts button class names and structure in `apps/mail/components/connection/add.tsx`, directly relating to the opacity styling changes made in this PR.
## Suggested reviewers
- nizzyabi
## Poem
> A rabbit hopped through fields of code,
> Adjusting shades where menus glowed.
> Now buttons shimmer, soft and bright,
> With hover magic, just so right.
> The icons gleam, the text stands tall—
> Unified style delights us all!
> 🐇✨📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (29)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/mail/components/ui/nav-user.tsx (1)
273-276: Consider updating the sign-in menu item for consistencyWhile most menu items have been updated to use container-level opacity styling, the sign-in menu item still has opacity applied to individual elements. Consider updating this item to match the styling pattern used elsewhere for complete consistency.
-<DropdownMenuItem className="cursor-pointer" onClick={() => router.push('/login')}> - <LogIn size={16} className="mr-2 opacity-60" /> - <p className="text-[13px] opacity-60">{t('common.navUser.signIn')}</p> +<DropdownMenuItem className="cursor-pointer opacity-60 hover:opacity-90" onClick={() => router.push('/login')}> + <LogIn size={16} className="mr-2" /> + <p className="text-[13px]">{t('common.navUser.signIn')}</p> </DropdownMenuItem>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/mail/components/connection/add.tsx(1 hunks)apps/mail/components/ui/nav-user.tsx(2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
apps/mail/components/connection/add.tsx (1)
apps/mail/lib/utils.ts (1)
cn(52-52)
🔇 Additional comments (5)
apps/mail/components/connection/add.tsx (1)
35-39: Positive styling refactor for consistent hover behaviorMoving the opacity styling from individual elements to the container level provides a more consistent hover experience for users. This approach ensures that the entire button and all its contents transition together, improving usability and visual consistency.
apps/mail/components/ui/nav-user.tsx (4)
237-246: Clean implementation of opacity at container levelGood implementation of opacity and hover effect at the container level for consistent visual behavior.
247-254: Good refactoring of className placementMoving the
cursor-pointerclass from the Link to the DropdownMenuItem and adding opacity styling at the container level improves consistency with other menu items.
255-268: Consistent styling across menu itemsThe opacity and hover styling has been consistently applied to the customer support and logout menu items, maintaining visual harmony.
297-302: Consistent styling for debug menu itemThe debug section menu item now follows the same styling pattern as other menu items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added hover for better visibility
Screen.Recording.2025-04-23.at.3.43.31.AM.mov
Screen.Recording.2025-04-23.at.3.43.05.AM.mov
By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.
Summary by CodeRabbit