Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPENDS ON ManageIQ/manageiq#17672] Add ServiceTemplate#schedules subcollection #412

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jul 5, 2018

Depends on: ManageIQ/manageiq#17672
Enables viewing schedules for ServiceTemplates for V2V
https://bugzilla.redhat.com/show_bug.cgi?id=1564255

@bdunne
Copy link
Member Author

bdunne commented Jul 5, 2018

@miq-bot add_label gaprindashvili/yes

@JPrause
Copy link
Member

JPrause commented Jul 6, 2018

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label Jul 6, 2018
@bdunne bdunne force-pushed the service_template_view_schedules branch from 61865b2 to 1d64551 Compare July 6, 2018 21:19
@bdunne bdunne force-pushed the service_template_view_schedules branch from 1d64551 to c58d1d4 Compare July 6, 2018 21:38
@miq-bot
Copy link
Member

miq-bot commented Jul 6, 2018

Checked commit bdunne@c58d1d4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@gtanzillo gtanzillo added this to the Sprint 90 Ending Jul 16, 2018 milestone Jul 9, 2018
@gtanzillo gtanzillo merged commit 74851f1 into ManageIQ:master Jul 9, 2018
@bdunne bdunne deleted the service_template_view_schedules branch July 9, 2018 18:52
simaishi pushed a commit that referenced this pull request Jul 25, 2018
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 78795ebbd213a185b13d630b10d3559cd56e92c2
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Mon Jul 9 14:40:35 2018 -0400

    Merge pull request #412 from bdunne/service_template_view_schedules
    
    [DEPENDS ON ManageIQ/manageiq#17672] Add ServiceTemplate#schedules subcollection
    (cherry picked from commit 74851f182102df596e808944eafb19f518acd6a2)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1608351

@simaishi
Copy link
Contributor

@bdunne Can you please take a look at Travis failures for Gaprindashvili branch?
https://travis-ci.org/ManageIQ/manageiq-api/builds/408072881

NoMethodError:
       undefined method `resource_id=' for #<MiqSchedule:0x0000001911c330>

@bdunne
Copy link
Member Author

bdunne commented Jul 25, 2018

ManageIQ/manageiq#17594 and ManageIQ/manageiq#17588 and ManageIQ/manageiq#17581 also need backport.

@simaishi
Copy link
Contributor

@bdunne Thank you. I backported ManageIQ/manageiq#17588 and ManageIQ/manageiq#17581. Will wait for you to create a Gaprindashvili PR for ManageIQ/manageiq#17594 and re-run Travis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants