Add resource relation to MiqSchedule #17581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 13, 2018
bdunne
force-pushed
the
miq_schedule_resources
branch
from
5774966
to
9247829
Compare
jrafanie
reviewed
Jun 14, 2018
app/models/miq_schedule.rb
Outdated
|
|
||
| _log.info("Queueing start of schedule id: [#{id}] [#{sched.name}] [#{sched.towhat}] [#{method}]...complete") | ||
| msg | ||
| else | ||
| _log.warn("[#{sched.name}] no such action: [#{method}], aborting schedule") | ||
| return |
There was a problem hiding this comment.
This return is redundant now, right?
jrafanie
reviewed
Jun 14, 2018
app/models/miq_schedule.rb
Outdated
| @@ -39,6 +42,11 @@ class MiqSchedule < ApplicationRecord | |||
| default_value_for :enabled, true | |||
| default_value_for(:zone_id) { MiqServer.my_server.zone_id } | |||
|
|
|||
| def resource | |||
| # HACK: this should be a real relation, but for now it's using a reserve_attribute for backport reasons | |||
| Object.const_get(towhat).find_by(:id => resource_id) | |||
There was a problem hiding this comment.
Are we deprecating towhat here? The commit says we are but maybe it's coming in a future PR?
bdunne
force-pushed
the
miq_schedule_resources
branch
from
9247829
to
01d3580
Compare
bdunne
force-pushed
the
miq_schedule_resources
branch
from
01d3580
to
4c3a53f
Compare
|
@jrafanie Thanks, I cleaned up the |
|
Checked commits bdunne/manageiq@e6991fd~...4c3a53f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
jrafanie
reviewed
Jun 15, 2018
| def resource | ||
| # HACK: this should be a real relation, but for now it's using a reserve_attribute for backport reasons | ||
| return unless resource_id | ||
| towhat.safe_constantize.find_by(:id => resource_id) |
There was a problem hiding this comment.
I can't unsee 'tow hat' now, thanks @bdunne
jrafanie
approved these changes
Jun 15, 2018
|
LGTM, I'll give others a little bit to verify the reserves usage since I haven't seen or used it in a while. |
gtanzillo
approved these changes
Jun 15, 2018
simaishi
pushed a commit
that referenced
this pull request
Jul 25, 2018
Add resource relation to MiqSchedule (cherry picked from commit 381f94a)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followups: