-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MiqSchedule call method directly if available #17588
MiqSchedule call method directly if available #17588
Conversation
This avoids having to create an action_ method in the MiqSchedule namespace
1b2c6f4
to
5565e64
Compare
Some comments on commit bdunne@5565e64 spec/models/miq_schedule_spec.rb
|
Checked commit bdunne@5565e64 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 spec/models/miq_schedule_spec.rb
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
MiqSchedule call method directly if available (cherry picked from commit 7202cbe)
Gaprindashvili backport details:
|
Based on: #17581
If the MiqSchedule#resource responds to the method, call it
This avoids having to create an action_ method in the MiqSchedule namespace