Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiqSchedule call method directly if available #17588

Merged
merged 4 commits into from
Jun 15, 2018

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jun 14, 2018

Based on: #17581

If the MiqSchedule#resource responds to the method, call it

This avoids having to create an action_ method in the MiqSchedule namespace

This avoids having to create an action_ method in the MiqSchedule namespace
@bdunne bdunne force-pushed the miq_schedule_call_method_directly branch from 1b2c6f4 to 5565e64 Compare June 14, 2018 20:40
@bdunne bdunne changed the title [WIP] MiqSchedule call method directly if available MiqSchedule call method directly if available Jun 15, 2018
@miq-bot miq-bot removed the wip label Jun 15, 2018
@miq-bot
Copy link
Member

miq-bot commented Jun 15, 2018

Some comments on commit bdunne@5565e64

spec/models/miq_schedule_spec.rb

  • ⚠️ - 740 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 749 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

@miq-bot
Copy link
Member

miq-bot commented Jun 15, 2018

Checked commit bdunne@5565e64 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

spec/models/miq_schedule_spec.rb

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@gtanzillo gtanzillo self-assigned this Jun 15, 2018
@gtanzillo gtanzillo added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 15, 2018
@gtanzillo gtanzillo merged commit 7202cbe into ManageIQ:master Jun 15, 2018
@bdunne bdunne deleted the miq_schedule_call_method_directly branch June 15, 2018 21:02
simaishi pushed a commit that referenced this pull request Jul 25, 2018
MiqSchedule call method directly if available
(cherry picked from commit 7202cbe)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 9624ca351517c29ec7a847462f43195d4e56e10c
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Fri Jun 15 16:43:41 2018 -0400

    Merge pull request #17588 from bdunne/miq_schedule_call_method_directly
    
    MiqSchedule call method directly if available
    (cherry picked from commit 7202cbeb532006870618eccac613e5477fd2cabe)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants