Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ruby 3.0 #206

Merged
merged 2 commits into from
Mar 21, 2023
Merged

support ruby 3.0 #206

merged 2 commits into from
Mar 21, 2023

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Mar 21, 2023

part of #205

rspec expectations.with now needs hashes to be explicitly passed as a hash

@kbrock kbrock added the ruby3 label Mar 21, 2023
@kbrock kbrock mentioned this pull request Mar 21, 2023
5 tasks
rspec expectations.with now needs hashes to be explicitly passed as a hash
@kbrock
Copy link
Member Author

kbrock commented Mar 21, 2023

update:

  • removed the fail-fast: false

@miq-bot
Copy link
Member

miq-bot commented Mar 21, 2023

Checked commits kbrock/manageiq-appliance_console@fe2d5b1~...80a7202 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
4 files checked, 3 offenses detected

spec/cli_spec.rb

@Fryguy Fryguy merged commit 7aa7ad1 into ManageIQ:master Mar 21, 2023
@Fryguy Fryguy self-assigned this Mar 21, 2023
@kbrock kbrock deleted the rails_30 branch March 21, 2023 18:15
Fryguy added a commit that referenced this pull request Feb 7, 2024
Fixed
- Fix sporadic test failure [#204]
- Remove MIQ specific gem source [#209]
- Double escape @ in realm to avoid shell interpretation [#211]
- Move gem name loader to proper namespaced location [#208]
- Separate kerberos from service principal name and use correctly [#215]
- Add manageiq user to allowed_uids for sssd [#220]
- Remove warning about using pg_dump [#221]
- Fix specs where AwesomeSpawn private interface changed [#224]
- Change the Name of the CA from something to ApplianceCA [#228]
- Fix YAML.load_file failing on aliases [#234]

Added
- Make backward compatible changes to work with repmgr13 - version 5.2.1 [#192]
- Support Ruby 3.0 [#206]
- Support Ruby 3.1 [#227]
- Allow rails 7 gems in gemspec [#226]

Changed
- Update to Highline 2.1.0 [#201]
- Clean up test output (highline and stdout messages) [#210]

Removed
- Drop Ruby 2.7 [#223]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants