Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rails 7 gems in gemspec #226

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Jan 12, 2024

Allow rails 7 gems in gemspec

The tests don't pull in manageiq, so I was able to add rails 7 to the test matrix.

@miq-bot
Copy link
Member

miq-bot commented Jan 18, 2024

Some comments on commits jrafanie/manageiq-appliance_console@6263a53~...d88fc40

spec/spec_helper.rb

  • ⚠️ - 44 - Detected puts. Remove all debugging statements.
  • ⚠️ - 45 - Detected puts. Remove all debugging statements.
  • ⚠️ - 46 - Detected puts. Remove all debugging statements.

@miq-bot
Copy link
Member

miq-bot commented Jan 18, 2024

Checked commits jrafanie/manageiq-appliance_console@6263a53~...d88fc40 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 1 offense detected

Gemfile

  • ❗ - Line 7, Col 8 - Style/FetchEnvVar - Use ENV.fetch('TEST_RAILS_VERSION') or ENV.fetch('TEST_RAILS_VERSION', nil) instead of ENV['TEST_RAILS_VERSION'].

@agrare agrare merged commit 793a6dd into ManageIQ:master Jan 18, 2024
4 checks passed
@jrafanie jrafanie deleted the allow_rails_7 branch January 18, 2024 14:34
@jrafanie jrafanie assigned agrare and unassigned kbrock Jan 18, 2024
@jrafanie jrafanie restored the allow_rails_7 branch January 19, 2024 15:00
@jrafanie jrafanie deleted the allow_rails_7 branch January 31, 2024 16:39
Fryguy added a commit that referenced this pull request Feb 7, 2024
Fixed
- Fix sporadic test failure [#204]
- Remove MIQ specific gem source [#209]
- Double escape @ in realm to avoid shell interpretation [#211]
- Move gem name loader to proper namespaced location [#208]
- Separate kerberos from service principal name and use correctly [#215]
- Add manageiq user to allowed_uids for sssd [#220]
- Remove warning about using pg_dump [#221]
- Fix specs where AwesomeSpawn private interface changed [#224]
- Change the Name of the CA from something to ApplianceCA [#228]
- Fix YAML.load_file failing on aliases [#234]

Added
- Make backward compatible changes to work with repmgr13 - version 5.2.1 [#192]
- Support Ruby 3.0 [#206]
- Support Ruby 3.1 [#227]
- Allow rails 7 gems in gemspec [#226]

Changed
- Update to Highline 2.1.0 [#201]
- Clean up test output (highline and stdout messages) [#210]

Removed
- Drop Ruby 2.7 [#223]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants