[GAPRINDASHVILI][POC] Store unique set size (USS) in the PSS column #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugzilla.redhat.com/show_bug.cgi?id=1479356 Unique set size is a better way to detect workers that are growing unbounded since any memory/reference leaks would be shown in their uss. If the server process is large when forking, new workers would inherit a big pss immediately. We should really rename the column/hash key to uss.
jrafanie
force-pushed
the
gaprindashvili_hack_uss_in_pss_column
branch
from
7c1273e
to
d155970
Compare
|
Checked commit jrafanie@d155970 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
This was referenced Nov 15, 2017
jrafanie
changed the title
|
For gaprindashvili and master, we should use ManageIQ/manageiq#16570 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1479356
Unique set size is a better way to detect workers that are growing
unbounded since any memory/reference leaks would be shown in their
uss. If the server process is large when forking, new workers would
inherit a big pss immediately.
We should really rename the column/hash key to uss.
Related PRs:
master
gaprindashvili
fine
euwe