[FINE][POC] Store unique set size (USS) in the PSS column #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
force-pushed
the
fine_hack_uss_in_pss_column
branch
from
475bdb2
to
a94b97b
Compare
This was referenced Nov 15, 2017
jrafanie
changed the title
https://bugzilla.redhat.com/show_bug.cgi?id=1479356 Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1526473 Unique set size is a better way to detect workers that are growing unbounded since any memory/reference leaks would be shown in their uss. If the server process is large when forking, new workers would inherit a big pss immediately. We should really rename the column/hash key to uss.
jrafanie
force-pushed
the
fine_hack_uss_in_pss_column
branch
from
a94b97b
to
d51285c
Compare
|
Checked commit jrafanie@d51285c with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1479356
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1526473
Unique set size is a better way to detect workers that are growing
unbounded since any memory/reference leaks would be shown in their
uss. If the server process is large when forking, new workers would
inherit a big pss immediately.
We should really rename the column/hash key to uss.
Related PRs:
master [Fixed correctly with schema changes] via ManageIQ/manageiq#16569 ManageIQ/manageiq#16570
gaprindashvili [Fixed correctly with schema changes] via ManageIQ/manageiq#16569 ManageIQ/manageiq#16570
fine
euwe