Save unique_set_size when saving process info #16569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label gaprindashvili/yes |
This was referenced Nov 30, 2017
|
@miq-bot add_label enhancement |
|
@gtanzillo @Fryguy I tested this PR along with it's two dependent PRs in schema and gems pending. This only stores USS in the database. It does NOT log it, show it in rake evm:status or change the worker monitor code to use USS for the threshold checking. Those will be done next. |
|
Merged both dependent PRs. |
Fryguy
approved these changes
Nov 30, 2017
jrafanie
changed the title
gtanzillo
approved these changes
Nov 30, 2017
Why? USS is a more reliable mechanism for tracking workers with runaway memory growth. PSS is great, until the server process that forks new processes grows large. As each new worker is forked, it inherits a share of the large amount of the parent process' memory and therefore starts with a large PSS, possibly exceeding our limits before doing any work. USS only measures a process' private memory and is a better indicator when a process is responsible for allocating too much memory without freeing it.
jrafanie
force-pushed
the
add_uss_to_servers_workers
branch
from
87ac247 to
a60fbdd
Compare
|
Checked commit jrafanie@a60fbdd with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 app/models/miq_worker.rb
|
|
@Fryguy This is finally 💚 🎉 |
simaishi
pushed a commit
that referenced
this pull request
Dec 1, 2017
Save unique_set_size when saving process info (cherry picked from commit d50a4d9)
|
Gaprindashvili backport details: |
This was referenced Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? USS is a more reliable mechanism for tracking workers with runaway
memory growth. PSS is great, until the server process that forks new
processes grows large. As each new worker is forked, it inherits a share
of the large amount of the parent process' memory and therefore starts
with a large PSS, possibly exceeding our limits before doing any work.
USS only measures a process' private memory and is a better indicator
when a process is responsible for allocating too much memory without
freeing it.
Depends on: