Use USS (unique set size) instead of PSS for all the things #16570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
force-pushed
the
USS_all_the_things
branch
from
2100ee9
to
76db86c
Compare
This was referenced Nov 30, 2017
jrafanie
changed the title
jrafanie
force-pushed
the
USS_all_the_things
branch
from
76db86c
to
14d890a
Compare
|
@gtanzillo @Fryguy this is now ready for review with the prior PR merged cc @dmetzger57 @NickLaMuro |
This was referenced Dec 14, 2017
|
Good point, let me put a BZ link @carbonin |
jrafanie
force-pushed
the
USS_all_the_things
branch
from
14d890a
to
04c8995
Compare
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1479356 Why? USS is a more reliable mechanism for tracking workers with runaway memory growth. PSS is great, until the server process that forks new processes grows large. As each new worker is forked, it inherits a share of the large amount of the parent process' memory and therefore starts with a large PSS, possibly exceeding our limits before doing any work. USS only measures a process' private memory and is a better indicator when a process is responsible for allocating too much memory without freeing it.
jrafanie
force-pushed
the
USS_all_the_things
branch
from
04c8995
to
ef84a88
Compare
|
Checked commits jrafanie/manageiq@2d75877~...ef84a88 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Dec 18, 2017
Use USS (unique set size) instead of PSS for all the things (cherry picked from commit eee0570) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1527093
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1479356
Builds on top of #16569 [MERGED]
The first bullet point should alleviate the false positives where a large server process was causing new forked workers to exceed PSS memory thresholds very quickly. If the server process grows over time, that's a separate problem. We shouldn't flag and kill workers that inherited a large shared memory, only ones that grow beyond the thresholds on their own.
For prior versions such as euwe and fine, we can accomplish a similar result by storing the USS in the existing PSS column: