Save persistent volume claim to project relation #108
Conversation
zeari
force-pushed
the
add_project_id_to_volume_claims
branch
from
6f51da0
to
78a5870
Compare
|
Checked commit zeari@78a5870 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
| @@ -189,6 +189,7 @@ def get_persistent_volume_claims(inventory) | |||
| process_collection(inventory["persistent_volume_claim"], key) { |n| parse_persistent_volume_claim(n) } | |||
| @data[key].each do |pvc| | |||
| @data_index.store_path(key, :by_namespace_and_name, pvc[:namespace], pvc[:name], pvc) | |||
| pvc[:project] = @data_index.fetch_path(path_for_entity("namespace"), :by_name, pvc[:namespace]) | |||
There was a problem hiding this comment.
Much of the parser sets :project instead of :container_project for some reason. I want to fix it one day.
Is it easy to do :container_project here? Or do you think it's better to keep the pattern?
There was a problem hiding this comment.
Much of the parser sets :project instead of :container_project for some reason. I want to fix it one day.
it's been bugging me too :) never got around to fixing it.
There was a problem hiding this comment.
keep the pattern. change it in the next refactor.
| @@ -371,6 +372,7 @@ def get_persistent_volume_claims_graph(inv) | |||
|
|
|||
| inv["persistent_volume_claim"].each do |pvc| | |||
| h = parse_persistent_volume_claim(pvc) | |||
| h[:container_project] = lazy_find_project(:name => h[:namespace]) | |||
There was a problem hiding this comment.
@cben so this has to be done in both refreshes since it involves data_index right? in cases where we change parsing (e.g add another textual field to an entity) we will have to update only the parse method?
There was a problem hiding this comment.
Yeah. A column on same table can be set once in parse_* method.
Links to other tables are done differently in 2 refreshes.
- The old refresh does links directly by nested hashes. sometimes it's implicit, nesting comes from
parse_*or directly from kubernetes. nesting across API requests is constructed viadata_index.
Then, in some cases depending on saving order, save_inventory needs to break nestings and set ids (this is the case add relation between container projects and persistent volume claims manageiq#15932). - Graph refresh does links within API request directly by linking InventoryObject, across API requests by lazy_find. (images & registries still unrefactored via
@data_index.)
Graph saving figures order automatically, no manual breaking needed.
|
Looks good, travis failing. |
|
Yes of course ¯_(ツ)_/¯ |
|
All tests green @moolitayer @cben @simon3z |
|
@moolitayer You're 2nd approver, and have merge powers, hint hint :) |
depends on:
ManageIQ/manageiq-schema#60
ManageIQ/manageiq#15932
@cben @moolitayer @zakiva Please review
cc @simon3z we are going to need this relation for chargeback so we can identify pvc's that are not connected to pods but are connected to a project