add relation between container projects and persistent volume claims #15932
Conversation
|
@zakiva Please review @miq-bot add_label providers/containers |
|
|
| @@ -42,9 +42,12 @@ def save_persistent_volume_claims_inventory(ems, hashes) | |||
| return if hashes.nil? | |||
|
|
|||
| ems.persistent_volume_claims.reset | |||
| hashes.each do |h| | |||
| h[:container_project_id] = h.fetch_path(:project, :id) | |||
There was a problem hiding this comment.
How about:
h[:container_project_id] = h.delete_path(:project)[:id]
and remove the ignored key from line 50. Not a big deal, to me it makes the parsing more self contained in terms of the hashes we output) I think we use both strategies now.
zeari
force-pushed
the
add_project_id_to_volume_claims
branch
from
a87e611
to
d66e647
Compare
@moolitayer Fixed |
|
Checked commit zeari@d66e647 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
| @@ -42,6 +42,9 @@ def save_persistent_volume_claims_inventory(ems, hashes) | |||
| return if hashes.nil? | |||
|
|
|||
| ems.persistent_volume_claims.reset | |||
| hashes.each do |h| | |||
| h[:container_project_id] = h.delete_path(:project)[:id] | |||
There was a problem hiding this comment.
can use just delete here. doesn't matter.
|
@Fryguy @blomquisg ManageIQ/manageiq-schema#60 was merged. Can we merge this one too? |
persistent_volume_claims are under a namespace\project. This PR adds the relation.
depends on
ManageIQ/manageiq-schema#60(merged)