Add container_project_id to persistent_volume_claims #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeari
force-pushed
the
add_project_id_to_volume_claims
branch
from
c89d312
to
fcb918d
Compare
|
Checked commit zeari@fcb918d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@zeari we will need a migration for existing records right? |
@moolitayer the relationship should be filled in the next inventory refresh |
cben
approved these changes
Sep 5, 2017
zakiva
approved these changes
Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed for ManageIQ/manageiq#15932 so we can add a
belongs_to :container_projectsrelation to persistent_volume_claims@zakiva Please review
cc @simon3z @cben @moolitayer