Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change method name that gets metrics default db name #431

Merged
merged 1 commit into from
Mar 4, 2017
Merged

Change method name that gets metrics default db name #431

merged 1 commit into from
Mar 4, 2017

Conversation

borod108
Copy link

The name of the method to get the default metrics db name in RHV
has changed.

this is dependent on: ManageIQ/manageiq#13981

Change method name that gets metrics default db name
fd5fa57 
The name of the method to get the default metrics db name in RHV
has changed.
This was referenced Feb 20, 2017
Merged
Merged
@borod108
Copy link
Author

borod108 commented Feb 20, 2017 •
edited
Loading

This, together with ManageIQ/manageiq#13981

solves: https://bugzilla.redhat.com/show_bug.cgi?id=1414077

@miq-bot
Copy link
Member

miq-bot commented Feb 20, 2017

Checked commit borod108@fd5fa57 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. ⭐

@borod108
Copy link
Author

@durandom this should be merged together with the ManageIQ/manageiq#13981

@durandom
Copy link
Member

@miq-bot remove_label pending core

@durandom
Copy link
Member

@miq-bot add_label bug
@miq-bot remove_label refactoring

@miq-bot miq-bot added bug and removed refactoring labels Feb 28, 2017
durandom
durandom approved these changes Feb 28, 2017
View reviewed changes
Copy link
Member

@durandom durandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miq-bot assign @mzazrivec

@mzazrivec please merge, the core PR has been merged

@borod108
Copy link
Author

@miq-bot add_label euwe/yes

@durandom
Copy link
Member

durandom commented Mar 2, 2017

@miq-bot assign @mzazrivec

@mzazrivec mzazrivec added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 4, 2017
@mzazrivec mzazrivec merged commit 749b467 into ManageIQ:master Mar 4, 2017
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2017

Euwe backport (to manageiq repo) details:

$ git log -1
commit aba87cdefd6ee2e18fd0c6c3e1ead826a5d4b4a1
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Sat Mar 4 20:17:20 2017 +0100

    Merge pull request #431 from borod108/bugs/metrics_database_auth_ui
    
    Change method name that gets metrics default db name
    (cherry picked from commit 749b46783d8f7c2c5cb7997be8827456c55585e4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1429649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durandom durandom durandom approved these changes

Assignees

@mzazrivec mzazrivec

Labels
bug euwe/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@borod108 @miq-bot @durandom @simaishi @dclarizio @mzazrivec