Use the provided database name during metric collection #13909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user provided a database name different from the default one it is was saved but not actually used when collecting the data. Instead the default one was used which caused a bug.
borod108
force-pushed
the
bugs/metrics_database_name
branch
from
7d5359a
to
124a5fe
Compare
|
Checked commit borod108@124a5fe with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@blomquisg hi, we had the policy of having this reviewed by a teammate before merge, this was not reviewed and confirmed, while this is a valid change it is not a full solution, I am currently working on it. Perhaps I should have changed this to [WIP] but since we have this process I did not think it will go in. |
|
This, together with #13981, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user provided a database name different from the default one
it is was saved but not actually used when collecting the data.
Instead the default one was used which caused a bug.