Fix authentication of metrics credentials in RHV #13981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@masayag please review. |
borod108
force-pushed
the
bugs/metrics_database_auth
branch
from
f082125
to
7e7f6ec
Compare
masayag
reviewed
Feb 20, 2017
| @@ -134,7 +134,7 @@ def rhevm_metrics_connect_options(options = {}) | |||
| server = options[:hostname] || metrics_hostname || hostname | |||
| username = options[:user] || authentication_userid(:metrics) | |||
| password = options[:pass] || authentication_password(:metrics) | |||
| database = options[:database] | |||
| database = options[:database] || history_database_name | |||
borod108
force-pushed
the
bugs/metrics_database_auth
branch
3 times, most recently
from
449c7e8
to
eee15ed
Compare
When the database name was not the default one the RHV metrics credentials would not use the right database name during authentication and fail. Removed some code that supported RHV 3.0 and needed to connect to the RHV api to find its version, so it caused some tests to fail.
borod108
force-pushed
the
bugs/metrics_database_auth
branch
from
eee15ed
to
1313a33
Compare
masayag
approved these changes
Feb 20, 2017
|
Checked commit borod108@1313a33 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
borod108
changed the title
Fryguy
changed the title
borod108
changed the title
masayag
approved these changes
Feb 23, 2017
durandom
suggested changes
Feb 27, 2017
|
@durandom I think it should be ok since the 3_0 thing is relevant up to 3.1 version of RHV which we do not support. For >3.2 it should work fine. |
|
@durandom Cannot apply the following label because they are not recognized: providers/rhvem |
|
Looks good thanks @borod108 ! |
|
@miq-bot remove_label euwe/yes |
simaishi
pushed a commit
that referenced
this pull request
Mar 8, 2017
Fix authentication of metrics credentials in RHV (cherry picked from commit 1f93c45) https://bugzilla.redhat.com/show_bug.cgi?id=1429649
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the database name was not the default one the RHV metrics credentials
would not use the right database name during authentication and fail.