[EmbeddedAnsible::CrudCommon] Fix manager validation #20880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting this back as this was used in the specs to validate the correct
manager was being used in the credential_spec.rb for `EmbeddedAnsible`:
it ".create_in_provider_queue will fail with incompatible manager" do
wrong_manager = FactoryBot.create(:configuration_manager_foreman)
expect { credential_class.create_in_provider_queue(wrong_manager.id, params) }.to raise_error(ActiveRecord::RecordNotFound)
end
While there may be a better way of doing this, deleting the spec seems
like the wrong way to fix this issue, and this was originally removed
because it was assumed it wasn't needed.
|
Checked commit NickLaMuro@89d3b8a with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
djberg96
reviewed
Dec 9, 2020
| @@ -50,6 +50,7 @@ def encrypt_queue_params(params) | |||
| end | |||
|
|
|||
| def create_in_provider_queue(manager_id, params, auth_user = nil) | |||
| parent.find(manager_id) # validation that the manager ID is from EmbeddedAnsible | |||
There was a problem hiding this comment.
If we're going to leave this in, then can we disable the Lint/UselessAssignment cop?
There was a problem hiding this comment.
@djberg96 I didn't assign anything, so there is nothing to disable. That is the one change I did make to this line.
agrare
approved these changes
Dec 9, 2020
|
👍 Thanks @NickLaMuro ... Minor, but performance-wise, this can probably be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting this back as this was used in the specs to validate the correct manager was being used in the credential_spec.rb for
EmbeddedAnsible:While there may be a better way of doing this, deleting the spec seems like the wrong way to fix this issue, and this was originally removed because it was assumed it wasn't needed.
For now, I at least added a comment in line, and fixed the unused variable issue so it is more apparent this is being used as a validation, and not the result being used later.
Links