Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EmbeddedAnsible::CrudCommon] Fix manager validation #20880

Merged
merged 1 commit into from
Dec 9, 2020
Merged

[EmbeddedAnsible::CrudCommon] Fix manager validation #20880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/models/manageiq/providers/embedded_ansible/crud_common.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ def encrypt_queue_params(params)
end

def create_in_provider_queue(manager_id, params, auth_user = nil)
parent.find(manager_id) # validation that the manager ID is from EmbeddedAnsible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to leave this in, then can we disable the Lint/UselessAssignment cop?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djberg96 I didn't assign anything, so there is nothing to disable. That is the one change I did make to this line.

action = "Creating #{self::FRIENDLY_NAME}"
action << " (name=#{params[:name]})" if params[:name]
queue(nil, "create_in_provider", [manager_id, encrypt_queue_params(params)], action, auth_user)
Expand Down