Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EmbeddedAnsible::CrudCommon] Fix manager validation #20880

Merged

Commits on Dec 8, 2020

  1. [EmbeddedAnsible::CrudCommon] Fix manager validation

    Putting this back as this was used in the specs to validate the correct
    manager was being used in the credential_spec.rb for `EmbeddedAnsible`:
    
      it ".create_in_provider_queue will fail with incompatible manager" do
        wrong_manager = FactoryBot.create(:configuration_manager_foreman)
        expect { credential_class.create_in_provider_queue(wrong_manager.id, params) }.to raise_error(ActiveRecord::RecordNotFound)
      end
    
    While there may be a better way of doing this, deleting the spec seems
    like the wrong way to fix this issue, and this was originally removed
    because it was assumed it wasn't needed.
    NickLaMuro committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    89d3b8a View commit details
    Browse the repository at this point in the history