Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a test case for CNC/Full Sized Rambo #16126

Merged
merged 3 commits into from
Dec 11, 2019

Conversation

jeffeb3
Copy link
Contributor

@jeffeb3 jeffeb3 commented Dec 6, 2019

Test case based on V1Engineering's CNC Dual Endstop Rambo configuration.

Requirements

Marlin's build tests should include a CNC configuration that includes a combination of CNC features.

Description

The V1Engineering CNC machines use a common set of features.

In an effort to keep those features from rotting with small errors, I've created a test configuration that should exercise the biggest features. I've excluded features that are probably tested elsewhere (_Bootscreen.h, Versions, etc.), but included features V1Engineering (@Allted) has included for CNC work.

Benefits

Benefits of tests are well known. This test is quite orthogonal to many of the 3D printing and board tests that currently exist.

Related Issues

#16108: This error is what keeps this CI test from passing. Once that is merged, this will pass.
Recreated from #16120, because I should have made it point to bugfix-2.0.x

@thinkyhead thinkyhead merged commit ae35045 into MarlinFirmware:bugfix-2.0.x Dec 11, 2019
@dseven
Copy link
Contributor

dseven commented Dec 12, 2019

Looks like CI has been failing on rambo since this merged.... https://travis-ci.org/MarlinFirmware/Marlin/pull_requests?utm_medium=notification&utm_source=github_status

@jeffeb3
Copy link
Contributor Author

jeffeb3 commented Dec 12, 2019

It was passing before it was merged. Was there another change that broke it after this PR passed it's test?

@jeffeb3
Copy link
Contributor Author

jeffeb3 commented Dec 12, 2019

As a shortcut. This seems to be the main issue:

In file included from Marlin/src/feature/../inc/../HAL/./HAL_AVR/HAL.h:23:0,
                 from Marlin/src/feature/../inc/../HAL/HAL.h:26,
                 from Marlin/src/feature/../inc/MarlinConfig.h:30,
                 from Marlin/src/feature/tmc_util.cpp:23:
Marlin/src/feature/../inc/../HAL/./HAL_AVR/fastio.h:81:35: error: pasting "DIO" and "-" does not give a valid preprocessing token
 #define _SET_OUTPUT(IO)       SBI(DIO ## IO ## _DDR, DIO ## IO ## _PIN)
                                   ^
Marlin/src/feature/../inc/../HAL/./HAL_AVR/fastio.h:101:31: note: in expansion of macro '_SET_OUTPUT'
 #define SET_OUTPUT(IO)        _SET_OUTPUT(IO)
                               ^
Marlin/src/feature/../inc/../HAL/./HAL_AVR/fastio.h:108:35: note: in expansion of macro 'SET_OUTPUT'
 #define OUT_WRITE(IO,V)       do{ SET_OUTPUT(IO); WRITE(IO,V); }while(0)
                                   ^
Marlin/src/feature/tmc_util.cpp:1056:26: note: in expansion of macro 'OUT_WRITE'
   #define SET_CS_PIN(st) OUT_WRITE(st##_CS_PIN, HIGH)
                          ^
Marlin/src/feature/tmc_util.cpp:1059:7: note: in expansion of macro 'SET_CS_PIN'
       SET_CS_PIN(X);
       ^

I'm not sure why the rambo is building anything in TMC. Or why it's trying to set the CS pin.

@jeffeb3
Copy link
Contributor Author

jeffeb3 commented Dec 12, 2019

Looks like the restore_configs disappeared. I put it back in this PR: #16206

bjh22 added a commit to bjh22/Marlin that referenced this pull request Dec 15, 2019
* bugfix-2.0.x: (1131 commits)
  TOUCH_MI_DEPLOY_XPOS fallback to X_MIN_POS (MarlinFirmware#16226)
  Fix bad #ifdef (MarlinFirmware#16227)
  Move status screen defines
  Improve A20M config
  Tweak some config names
  Cardreader read/write open methods
  Include Z in SCARA steps feedrate (MarlinFirmware#16193)
  Update M503 MBL G29 report (MarlinFirmware#16199)
  Fix compile error (macro substitution typo) (MarlinFirmware#16194)
  Add MKS Robin Mini EEPROM defines (MarlinFirmware#16203)
  Flsun QQ-S example config (MarlinFirmware#16204)
  Fix RAMBo CNC test
  Tweak ExtUI Probeless Babystepping (MarlinFirmware#16177)
  Onboard (always-on) pullups support (MarlinFirmware#16144)
  Add a CI test for RAMBo + CNC (MarlinFirmware#16126)
  Disable SD_CHECK_AND_RETRY in BTT E3 configs (MarlinFirmware#16143)
  Invert E dir of Geeetech A10 (MarlinFirmware#16149)
  MKS 12864 OLED pins for SGEN-L (MarlinFirmware#16188)
  Update BTT comments for USB/SD Composite (MarlinFirmware#16130)
  Use error message !! hints (MarlinFirmware#16145)
  ...

# Conflicts:
#	Marlin/Configuration.h
#	Marlin/Configuration_adv.h
#	Marlin/src/pins/lpc1768/pins_BTT_SKR_V1_3.h
#	platformio.ini
LinoBarreca pushed a commit to LinoBarreca/Marlin that referenced this pull request Dec 18, 2019
philippniethammer pushed a commit to philippniethammer/Marlin that referenced this pull request Dec 21, 2019
christran206 pushed a commit to christran206/Marlin2.0-SKR-Mini-E3-1.2 that referenced this pull request Dec 30, 2019
webs1821 added a commit to webs1821/Marlin that referenced this pull request Jan 2, 2020
* [cron] Bump distribution date

* STM32F1 Flash-based EEPROM fixes (MarlinFirmware#16118)

* Disable PRINTCOUNTER in SKR Mini E3 examples (MarlinFirmware#16110)

* Fix compile error with disabled PIDTEMP (MarlinFirmware#16108)

* Wanhao D6 uses TINYBOY2 (MarlinFirmware#16117)

* Improve touch buttons behavior (MarlinFirmware#16109)

* Update AZSMZ LCD link (MarlinFirmware#16106)

* [cron] Bump distribution date

* Update 3DFabXYZ settings (MarlinFirmware#16139)

* [cron] Bump distribution date

* Fix controller and SD on Robin Nano (MarlinFirmware#16187)

* Correct MKS Robin Mini pins (MarlinFirmware#16178)

* Formalize DAC percent strings (MarlinFirmware#16176)

* Update Italian language (MarlinFirmware#16147)

* Update french (objects, retract...)

* Superscript 3 for mm3

* [cron] Bump distribution date

* Add MKS Robin Pro, MKS Robin Lite3 (MarlinFirmware#16163)

* Fix multiple servos with STM32 (MarlinFirmware#16151)

* Use error message !! hints (MarlinFirmware#16145)

* Update BTT comments for USB/SD Composite (MarlinFirmware#16130)

* MKS 12864 OLED pins for SGEN-L (MarlinFirmware#16188)

* Invert E dir of Geeetech A10 (MarlinFirmware#16149)

* Disable SD_CHECK_AND_RETRY in BTT E3 configs (MarlinFirmware#16143)

* Add a CI test for RAMBo + CNC (MarlinFirmware#16126)

* Onboard (always-on) pullups support (MarlinFirmware#16144)

* Tweak ExtUI Probeless Babystepping (MarlinFirmware#16177)

* Fix RAMBo CNC test

* Flsun QQ-S example config (MarlinFirmware#16204)

* Add MKS Robin Mini EEPROM defines (MarlinFirmware#16203)

* Fix compile error (macro substitution typo) (MarlinFirmware#16194)

* Update M503 MBL G29 report (MarlinFirmware#16199)

* Include Z in SCARA steps feedrate (MarlinFirmware#16193)

* Cardreader read/write open methods

* Tweak some config names

* Improve A20M config

* Move status screen defines

* Fix bad #ifdef (MarlinFirmware#16227)

* TOUCH_MI_DEPLOY_XPOS fallback to X_MIN_POS (MarlinFirmware#16226)

* Fix MKS SGen-L SD detect pin (MarlinFirmware#16224)

* Improve ESP32 HAL (EEPROM, watchdog) (MarlinFirmware#16228)

* Fix G28 debug line, M569 calls (MarlinFirmware#16213)

* Add SKR Mini E3 + Zonestar LCD warning (MarlinFirmware#16214)

* STM32 Touch UI timings, Longer onboard pullups (MarlinFirmware#16219)

* Update BTT002 platform (fixing SD init) (MarlinFirmware#16217)

* Define more FAN pins for GT2560 (MarlinFirmware#16235)

* Tweak E180 config

* Update product links

* [cron] Bump distribution date

* Add dev-2.1.x to 'mfinfo' script

* Move AutoBuildMarlin to its own repo

* [cron] Bump distribution date

* Tweak G34, fix a declaration

* Sanity-check Z_STEPPER_AUTO_ALIGN coordinates (MarlinFirmware#16231)

* Improve SKR mini E3 + Ender 3 settings (MarlinFirmware#16247)

* Tweak code formatting

* Allow TMC2209 to save/restore spreadCycle (MarlinFirmware#16153)

Co-Authored-By: teemuatlut <teemu.mantykallio@live.fi>

* Spindle/Laser pins for RADDS (MarlinFirmware#16119)

* Improve pulse timing and step reliability (MarlinFirmware#16128)

* BigTreeTech SKR v1.4 support (MarlinFirmware#16236)

* Followup to TMC2209 spreadcycle patch

* Remove obsolete TMC2209 comment

* HOME_USING_SPREADCYCLE is obsolete

Co-Authored-By: teemuatlut <teemu.mantykallio@live.fi>

* Use MYSERIAL0 (not SerialUSB) for Malyan LCD

* Followup for step timing (MarlinFirmware#16128)

* Fix broken M100_dump_routine

* Tweak sanity checks

* Update test scripts to error on unknown (MarlinFirmware#16229)

* Kossel Clear configuration (MarlinFirmware#16198)

* Move pins debug condition

* Use Github Actions for CI, date bump (MarlinFirmware#16269)

* Fix HAL_STM32 + Arduino IDE SoftwareSerial conflict (MarlinFirmware#16266)

* Improve Anet A6 config (MarlinFirmware#16280)

* Fix G34 with Z_DUAL_STEPPER_DRIVERS compile (MarlinFirmware#16274)

* Fix planner compile error (MarlinFirmware#16272)

* Fix axis CS sanity check (MarlinFirmware#16271)

* Add Tevo Nereus (w/ Robin Nano) config (MarlinFirmware#16207)

* Don't test certain changes

* Reset runout.ran_out on resume (MarlinFirmware#16230)

* Step timing cleanup and rounding fix (MarlinFirmware#16258)

* Add MRR_ESPA/_ESPE (ESP32) boards (MarlinFirmware#16238)

* Add Ender-5 Pro config (MarlinFirmware#16221)

* Add FLYBOARD (STM32F407ZG) (MarlinFirmware#16257)

* Fix STM32 flush of TX (used by UBL) (MarlinFirmware#16197)

* Flash leveling (for some STM32) (MarlinFirmware#16174)

* Some ESP32 patches (MarlinFirmware#16297)

* MKS SGen-L pins EEBF or EFBF scheme (MarlinFirmware#16296)

* Release version 2.0.0

* Add Rumba32 support for PIO (MarlinFirmware#16202)

* MKS Robin 2 (STM32F407ZE) base support (MarlinFirmware#16270)

* Update Czech language (MarlinFirmware#16305)

* Sync SKR E3 configs (MarlinFirmware#16301)

* Add NOZZLE_AS_PROBE (no probe offsets) (MarlinFirmware#15929)

* Version 2.0.1

* Update build status url

Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Co-authored-by: randellhodges <rhodges@taxfodder.com>
Co-authored-by: Jason Smith <jason.inet@gmail.com>
Co-authored-by: Antti Andreimann <anttix@users.sourceforge.net>
Co-authored-by: thisiskeithb <13375512+thisiskeithb@users.noreply.github.com>
Co-authored-by: Tanguy Pruvot <tpruvot@users.noreply.github.com>
Co-authored-by: Luu Lac <45380455+shitcreek@users.noreply.github.com>
Co-authored-by: Alain Martel <alain74martel@gmail.com>
Co-authored-by: Anders Sahlman <57940217+AndersSahlman@users.noreply.github.com>
Co-authored-by: dagorel <37673727+dagorel@users.noreply.github.com>
Co-authored-by: Giuliano Zaro <3684609+GMagician@users.noreply.github.com>
Co-authored-by: MS1987 <lms228@163.com>
Co-authored-by: MangaValk <patrickvalkmanga@hotmail.com>
Co-authored-by: André Kjellstrup <andre.kjellstrup@gmail.com>
Co-authored-by: Tobias Schürg <tobiasschuerg@gmail.com>
Co-authored-by: Jeff Eberl <jeffeb3@gmail.com>
Co-authored-by: ManuelMcLure <manuel@mclure.org>
Co-authored-by: InsanityAutomation <38436470+InsanityAutomation@users.noreply.github.com>
Co-authored-by: iain MacDonnell <github@dseven.org>
Co-authored-by: Bo Herrmannsen <bo.herrmannsen@gmail.com>
Co-authored-by: Luc <8822552+luc-github@users.noreply.github.com>
Co-authored-by: danym21 <54744475+danym21@users.noreply.github.com>
Co-authored-by: chzj333 <53591189+chzj333@users.noreply.github.com>
Co-authored-by: Vertabreaker <opyrus@hotmail.com>
Co-authored-by: Moshi Binyamini <MoshiBin@users.noreply.github.com>
Co-authored-by: salami738 <24863070+salami738@users.noreply.github.com>
Co-authored-by: elementfoundry <57408038+elementfoundry@users.noreply.github.com>
Co-authored-by: teemuatlut <teemu.mantykallio@live.fi>
Co-authored-by: Mario Costa <mario.silva.costa@gmail.com>
Co-authored-by: BigTreeTech <38851044+bigtreetech@users.noreply.github.com>
Co-authored-by: Markus Towara <mtowara@gmail.com>
Co-authored-by: FLYmaker <49380822+FLYmaker@users.noreply.github.com>
Co-authored-by: ferengi82 <christian.maurer@gmx.eu>
Co-authored-by: petrzjunior <junior@zahradnik.cz>
griehsler pushed a commit to griehsler/Marlin that referenced this pull request Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants