Bugfix G28 debug and sensorless homing with spreadcycle enabled.

[danym21]

Requirements

There are small bugs in G28. when debug is enabled it can not be compiled.
homing with spreadcycle enabled was not working regarding a typo.

Description

smal Bugfix in G28

Benefits

fix homing with spreadCycle.
fix debug

[boelle]

are there an open issue for this fix?

[danym21]

I have searched for but not found.

[tpruvot]

on which platform does that cause issues ? base branch of the PR is wrong, btw...

[boelle]

not anymore, thanks for spotting that

[danym21]

@boelle many thx for the move, sorry for that.
@tpruvot I think the platform does´n matter I normaly use the Bigtrettech SKR Pro 1.1
but als on the atmega 2560 you can not compile when you have sensoreless homing, home_current and debug_leveling_feature active:

Compiling .pio\build\megaatmega2560\src\src\gcode\calibrate\M852.cpp.o
Compiling .pio\build\megaatmega2560\src\src\gcode\config\M200-M205.cpp.o
Marlin\src\gcode\calibrate\G28.cpp:265:64: error: macro "SERIAL_ECHOLNPGM" passed 4 arguments, but takes just 1
       DEBUG_ECHO(s); DEBUG_ECHOLNPGM(" current: ", a, " -> ", b);
                                                                ^
Compiling .pio\build\megaatmega2560\src\src\gcode\config\M217.cpp.o
Compiling .pio\build\megaatmega2560\src\src\gcode\config\M218.cpp.o
Compiling .pio\build\megaatmega2560\src\src\gcode\config\M220.cpp.o

to reproduce you can do the following changes in the config:
Configuration.h

@ -638,13 +638,13 @@
#endif

// Mechanical endstop with COM to ground and NC to Signal uses "false" here (most common setup).
#define X_MIN_ENDSTOP_INVERTING false // Set to true to invert the logic of the endstop.
#define Y_MIN_ENDSTOP_INVERTING false // Set to true to invert the logic of the endstop.
#define X_MIN_ENDSTOP_INVERTING true // Set to true to invert the logic of the endstop.
#define Y_MIN_ENDSTOP_INVERTING true // Set to true to invert the logic of the endstop.
#define Z_MIN_ENDSTOP_INVERTING false // Set to true to invert the logic of the endstop.
#define X_MAX_ENDSTOP_INVERTING false // Set to true to invert the logic of the endstop.
#define Y_MAX_ENDSTOP_INVERTING false // Set to true to invert the logic of the endstop.
#define Z_MAX_ENDSTOP_INVERTING false // Set to true to invert the logic of the endstop.
#define Z_MIN_PROBE_ENDSTOP_INVERTING false // Set to true to invert the logic of the probe.
#define Z_MIN_PROBE_ENDSTOP_INVERTING true // Set to true to invert the logic of the probe.

/**
 * Stepper Drivers
@ -661,12 +661,12 @@
 *          TMC5130, TMC5130_STANDALONE, TMC5160, TMC5160_STANDALONE
 * :['A4988', 'A5984', 'DRV8825', 'LV8729', 'L6470', 'TB6560', 'TB6600', 'TMC2100', 'TMC2130', 'TMC2130_STANDALONE', 'TMC2160', 'TMC2160_STANDALONE', 'TMC2208', 'TMC2208_STANDALONE', 'TMC2209', 'TMC2209_STANDALONE', 'TMC26X', 'TMC26X_STANDALONE', 'TMC2660', 'TMC2660_STANDALONE', 'TMC5130', 'TMC5130_STANDALONE', 'TMC5160', 'TMC5160_STANDALONE']
 */
//#define X_DRIVER_TYPE  A4988
//#define Y_DRIVER_TYPE  A4988
//#define Z_DRIVER_TYPE  A4988
#define X_DRIVER_TYPE  TMC5160
#define Y_DRIVER_TYPE  TMC5160
#define Z_DRIVER_TYPE  TMC5160
//#define X2_DRIVER_TYPE A4988
//#define Y2_DRIVER_TYPE A4988
//#define Z2_DRIVER_TYPE A4988
#define Z2_DRIVER_TYPE TMC5160
//#define Z3_DRIVER_TYPE A4988
//#define E0_DRIVER_TYPE A4988
//#define E1_DRIVER_TYPE A4988
@ -1179,7 +1179,7 @@
 * Turn on with the command 'M111 S32'.
 * NOTE: Requires a lot of PROGMEM!
 */
//#define DEBUG_LEVELING_FEATURE
#define DEBUG_LEVELING_FEATURE

#if ANY(MESH_BED_LEVELING, AUTO_BED_LEVELING_BILINEAR, AUTO_BED_LEVELING_UBL)
  // Gradually reduce leveling correction until a set height is reached,

Configuration_adv.h:

@ -1881,7 +1881,7 @@

  #if AXIS_IS_TMC(X)
    #define X_CURRENT       800        // (mA) RMS current. Multiply by 1.414 for peak current.
    #define X_CURRENT_HOME  X_CURRENT  // (mA) RMS current for sensorless homing
    #define X_CURRENT_HOME  400  // (mA) RMS current for sensorless homing
    #define X_MICROSTEPS     16    // 0..256
    #define X_RSENSE          0.11
    #define X_CHAIN_POS      -1    // <=0 : Not chained. 1 : MCU MOSI connected. 2 : Next in chain, ...
@ -2000,7 +2000,7 @@
   * The default SW SPI pins are defined the respective pins files,
   * but you can override or define them here.
   */
  //#define TMC_USE_SW_SPI
  #define TMC_USE_SW_SPI
  //#define TMC_SW_MOSI       -1
  //#define TMC_SW_MISO       -1
  //#define TMC_SW_SCK        -1
@ -2075,7 +2075,7 @@
   * M912 - Clear stepper driver overtemperature pre-warn condition flag.
   * M122 - Report driver parameters (Requires TMC_DEBUG)
   */
  //#define MONITOR_DRIVER_STATUS
  #define MONITOR_DRIVER_STATUS

  #if ENABLED(MONITOR_DRIVER_STATUS)
    #define CURRENT_STEP_DOWN     50  // [mA]
@ -2131,7 +2131,7 @@
   *
   * TMC2209 requires STEALTHCHOP enabled for SENSORLESS_HOMING
   */
  //#define SENSORLESS_HOMING // StallGuard capable drivers only
  #define SENSORLESS_HOMING // StallGuard capable drivers only

  /**
   * Use StallGuard2 to probe the bed with the nozzle.

regearding this :
G28.cpp Line 291
process_subcommands_now_P(PSTR("M569S0XY"));
G28.cpp Line 520
process_subcommands_now_P(PSTR("M569S1XY"));

I think here the spaces are missing.
do I have missed something?

[thinkyhead]

It looks like you started from the 2.0.x branch. You should have started with the bugfix-2.0.x branch. Be sure to start with the bugfix-2.0.x branch and be careful to target bugfix-2.0.x when submitting PRs. It may help to set your fork's default branch to bugfix-2.0.x.

See http://marlinfw.org/docs/development/getting_started_pull_requests.html for full instructions.

I'll try to repair this PR by doing a rebase and deleting some commits from your branch.

[thinkyhead]

Your 2.0.x branch now contains the contents of bugfix-2.0.x plus this PR's commits. After this PR is merged, you might want to restore your 2.0.x branch to match ours. So at that time you will need to use the Git Console and the commands…

git fetch upstream
git checkout 2.0.x
git reset --hard upstream/2.0.x
git push -f origin

[thinkyhead]

G-code doesn't require spaces between parameters. So if M569S0XY isn't working but M569 S0 X Y is, then we'll need to debug the G-code parser.