Adding custom move feedrate for G26 #20729

ScrewThisBanana · 2021-01-09T14:35:10Z

Requirements

G26_MESH_VALIDATION enabled in configuration, no additional requirements

Description

This commit adds an additional configuration parameter (G26_XY_FEEDRATE_MOVE) in the Configuration.h file that can be used to specify the movement speed during the G26 validation pattern command during moves without extrusion.

The added feature was tested on my personal printer (TwoTrees Sapphire Pro) and works like a charm. Only x/y movements without e components take the newly introduced feedrate. All other behaviours of the G26 command stay the same.

Benefits

The amount of time used for G26 is drastically reduced as the feedrate for print moves is now different from moves without E-components

Configurations

platformio.ini.txt
Configuration.h.txt

Related Issues

Closes #20615

This commit adds an additional configuration parameter that can be used to specify the movement speed during the G26 validation pattern command during moves without extrusion. Closes MarlinFirmware#20615

This commit adds a default 'G26_XY_FEEDRATE_MOVE' value (max movement speed / 1.5) in the G26.cpp - same behaviour as the default 'G26_XY_FEEDRATE' value

qwewer0 · 2021-01-09T17:30:32Z

I think G26_XY_FEEDRATE_TRAVEL would reflect the setting more, and maybe 100 would be safer, while still acceptable as default value.
@ScrewThisBanana What do you think?

qwewer0 · 2021-01-10T14:33:53Z

Tried it out, works as expected.

ScrewThisBanana · 2021-01-10T15:43:33Z

I think G26_XY_FEEDRATE_TRAVEL would reflect the setting more, and maybe 100 would be safer, while still acceptable as default value.
@ScrewThisBanana What do you think?

I will change that two topics tomorrow

Configuration parameter renamed for better readability and consistency MarlinFirmware#20615

ScrewThisBanana · 2021-01-15T14:42:50Z

I think G26_XY_FEEDRATE_TRAVEL would reflect the setting more, and maybe 100 would be safer, while still acceptable as default value.
@ScrewThisBanana What do you think?

I will change that two topics tomorrow

"Tomorrow" is relative - fixed now ^^ See 2344ac4

Marlin/Configuration.h

Changed default value for 'G26_XY_FEEDRATE_TRAVEL' from 150 mm/s to 100 mm/s for safety purposes, comment alignment MarlinFirmware#20615

qwewer0 · 2021-01-15T16:16:55Z

Marlin/Configuration.h

@@ -1361,6 +1361,7 @@
    #define MESH_TEST_HOTEND_TEMP  205    // (°C) Default nozzle temperature for the G26 Mesh Validation Tool.
    #define MESH_TEST_BED_TEMP      60    // (°C) Default bed temperature for the G26 Mesh Validation Tool.
    #define G26_XY_FEEDRATE         20    // (mm/s) Feedrate for XY Moves for the G26 Mesh Validation Tool.
+    #define G26_XY_FEEDRATE_TRAVEL  100   // (mm/s) Feedrate for XY Moves without extrusion for the G26 Mesh Validation Tool


Decimal point should be aligned for all.

By the way, your change regarding the decimal point alignment is done in the new (needed) PR #20879 in commit 5d930a3 - I finally understood what you wanted from me ;) I hope that is ok for you?

All ok, thank you.

Roxy-3D · 2021-01-23T03:01:58Z

@ScrewThisBanana This is a long overdue improvement.

Thank You!

Roxy-3D · 2021-01-24T01:06:46Z

@ScrewThisBanana Ooooops! I shouldn't have merged this yet. We need to keep all the example Configuration.h files synchronized with the default Configuration.h file. I need to revert this.

As soon as the Example Configuration.h files have the new option in them we can continue.

UPDATE: I reverted the changes. I have very little time right now, but over the next couple of days I'll try to create a new Pull Request with your changes and the option added to all of the Configuration.h files. (And at that point it can be merged.) Or as an alternative, you can create a new Pull Request with all of the desired changes. Either path works for me.

This reverts commit 14567f3.

ScrewThisBanana · 2021-01-24T16:42:27Z

@Roxy-3D how should I proceed? Pull example configuration files from https://github.com/MarlinFirmware/Configurations and add the new configuration parameter in each example configuration file?

Roxy-3D · 2021-01-24T22:19:23Z

@ScrewThisBanana I apologize! I seem to be a little bit out of the loop. What I said used to be very true. All of the (many) Example Configuration.h files needed to be updated to reflect any new options added. But that is no longer true.

What you had was sufficient and I should not have reverted the merge. I don't think there is an easy way for me to recover the original Pull Request. If you can start a fresh Pull Request with the exact changes reflected up above, I will get it merged again.

ScrewThisBanana · 2021-01-25T18:04:31Z

@Roxy-3D A new pull request (#20879) was opened, feel free to try again ;)

…_bugfix * commit '876c2586b9146dd123af4c7b21138b8239ef5d39': (116 commits) Clean up MMU2 code (MarlinFirmware#20794) Init KILL, SUICIDE, PSU earlier (MarlinFirmware#20810) "Move … code" followup (MarlinFirmware#20869) Apply SEC_TO_MS and other fixes Reformat abortSDPrinting Fix sign warning (MarlinFirmware#20872) Cosmetic changes (2) (MarlinFirmware#20876) "Move … code" followup (MarlinFirmware#20868) "Move … code" followup (MarlinFirmware#20874) Graphical TFT fixes, cleanup (MarlinFirmware#20861) 🧻 Cosmetic changes (MarlinFirmware#20859) 🛠Fix deps script version regex Fix Ender 3 V2 DWIN manual move (MarlinFirmware#20837) [cron] Bump distribution date (2021-01-25) Fix LiquidCrystal CI failures (MarlinFirmware#20873) Revert "Adding custom move feedrate for G26 (MarlinFirmware#20729)" (MarlinFirmware#20870) MeatPack serial encoding (MarlinFirmware#20802) [cron] Bump distribution date (2021-01-24) lcd_put_wchar_max for COLOR_UI (MarlinFirmware#20838) Adding custom move feedrate for G26 (MarlinFirmware#20729) ... # Conflicts: # Marlin/Configuration.h # Marlin/Configuration_adv.h

qwewer0 · 2021-01-25T20:06:45Z

@Roxy-3D Can you remove/delete revert-20729-bugfix-2.0.x branch? I think it served it's purpose and will only cause confusion.

…0879) * Adding custom move feedrate for G26 This commit adds an additional configuration parameter that can be used to specify the movement speed during the G26 validation pattern command during moves without extrusion. Closes #20615

…ware#20729 (MarlinFirmware#20879) * Adding custom move feedrate for G26 This commit adds an additional configuration parameter that can be used to specify the movement speed during the G26 validation pattern command during moves without extrusion. Closes MarlinFirmware#20615

* Adding custom move feedrate for G26 This commit adds an additional configuration parameter that can be used to specify the movement speed during the G26 validation pattern command during moves without extrusion. Closes MarlinFirmware#20615 * Fixing missing default 'G26_XY_FEEDRATE_MOVE' value This commit adds a default 'G26_XY_FEEDRATE_MOVE' value (max movement speed / 1.5) in the G26.cpp - same behaviour as the default 'G26_XY_FEEDRATE' value * Adding comment describing functionality in G26.cpp * Renaming 'G26_XY_FEEDRATE_MOVE' to 'G26_XY_FEEDRATE_TRAVEL' Configuration parameter renamed for better readability and consistency MarlinFirmware#20615 * Setting 'G26_XY_FEEDRATE_TRAVEL' to a safer value, aligned comments Changed default value for 'G26_XY_FEEDRATE_TRAVEL' from 150 mm/s to 100 mm/s for safety purposes, comment alignment MarlinFirmware#20615

…arlinFirmware#20870) This reverts commit 14567f3.

…ware#20729 (MarlinFirmware#20879) * Adding custom move feedrate for G26 This commit adds an additional configuration parameter that can be used to specify the movement speed during the G26 validation pattern command during moves without extrusion. Closes MarlinFirmware#20615

* Adding custom move feedrate for G26 This commit adds an additional configuration parameter that can be used to specify the movement speed during the G26 validation pattern command during moves without extrusion. Closes MarlinFirmware#20615 * Fixing missing default 'G26_XY_FEEDRATE_MOVE' value This commit adds a default 'G26_XY_FEEDRATE_MOVE' value (max movement speed / 1.5) in the G26.cpp - same behaviour as the default 'G26_XY_FEEDRATE' value * Adding comment describing functionality in G26.cpp * Renaming 'G26_XY_FEEDRATE_MOVE' to 'G26_XY_FEEDRATE_TRAVEL' Configuration parameter renamed for better readability and consistency MarlinFirmware#20615 * Setting 'G26_XY_FEEDRATE_TRAVEL' to a safer value, aligned comments Changed default value for 'G26_XY_FEEDRATE_TRAVEL' from 150 mm/s to 100 mm/s for safety purposes, comment alignment MarlinFirmware#20615

…arlinFirmware#20870) This reverts commit 14567f3.

…ware#20729 (MarlinFirmware#20879) * Adding custom move feedrate for G26 This commit adds an additional configuration parameter that can be used to specify the movement speed during the G26 validation pattern command during moves without extrusion. Closes MarlinFirmware#20615

* Adding custom move feedrate for G26 This commit adds an additional configuration parameter that can be used to specify the movement speed during the G26 validation pattern command during moves without extrusion. Closes MarlinFirmware#20615 * Fixing missing default 'G26_XY_FEEDRATE_MOVE' value This commit adds a default 'G26_XY_FEEDRATE_MOVE' value (max movement speed / 1.5) in the G26.cpp - same behaviour as the default 'G26_XY_FEEDRATE' value * Adding comment describing functionality in G26.cpp * Renaming 'G26_XY_FEEDRATE_MOVE' to 'G26_XY_FEEDRATE_TRAVEL' Configuration parameter renamed for better readability and consistency MarlinFirmware#20615 * Setting 'G26_XY_FEEDRATE_TRAVEL' to a safer value, aligned comments Changed default value for 'G26_XY_FEEDRATE_TRAVEL' from 150 mm/s to 100 mm/s for safety purposes, comment alignment MarlinFirmware#20615

…arlinFirmware#20870) This reverts commit 14567f3.

…ware#20729 (MarlinFirmware#20879) * Adding custom move feedrate for G26 This commit adds an additional configuration parameter that can be used to specify the movement speed during the G26 validation pattern command during moves without extrusion. Closes MarlinFirmware#20615

* Adding custom move feedrate for G26 This commit adds an additional configuration parameter that can be used to specify the movement speed during the G26 validation pattern command during moves without extrusion. Closes #20615 * Fixing missing default 'G26_XY_FEEDRATE_MOVE' value This commit adds a default 'G26_XY_FEEDRATE_MOVE' value (max movement speed / 1.5) in the G26.cpp - same behaviour as the default 'G26_XY_FEEDRATE' value * Adding comment describing functionality in G26.cpp * Renaming 'G26_XY_FEEDRATE_MOVE' to 'G26_XY_FEEDRATE_TRAVEL' Configuration parameter renamed for better readability and consistency #20615 * Setting 'G26_XY_FEEDRATE_TRAVEL' to a safer value, aligned comments Changed default value for 'G26_XY_FEEDRATE_TRAVEL' from 150 mm/s to 100 mm/s for safety purposes, comment alignment #20615

This reverts commit 14567f3.

…0879) * Adding custom move feedrate for G26 This commit adds an additional configuration parameter that can be used to specify the movement speed during the G26 validation pattern command during moves without extrusion. Closes #20615

ScrewThisBanana added 3 commits December 31, 2020 17:47

Adding custom move feedrate for G26

be819a7

This commit adds an additional configuration parameter that can be used to specify the movement speed during the G26 validation pattern command during moves without extrusion. Closes MarlinFirmware#20615

Fixing missing default 'G26_XY_FEEDRATE_MOVE' value

90f08f1

This commit adds a default 'G26_XY_FEEDRATE_MOVE' value (max movement speed / 1.5) in the G26.cpp - same behaviour as the default 'G26_XY_FEEDRATE' value

Adding comment describing functionality in G26.cpp

f328f8f

ScrewThisBanana mentioned this pull request Jan 9, 2021

[FR] Custom movement speed during G26 validation pattern #20615

Closed

Renaming 'G26_XY_FEEDRATE_MOVE' to 'G26_XY_FEEDRATE_TRAVEL'

2344ac4

Configuration parameter renamed for better readability and consistency MarlinFirmware#20615

qwewer0 reviewed Jan 15, 2021

View reviewed changes

Marlin/Configuration.h Outdated Show resolved Hide resolved

Setting 'G26_XY_FEEDRATE_TRAVEL' to a safer value, aligned comments

aaa873e

Changed default value for 'G26_XY_FEEDRATE_TRAVEL' from 150 mm/s to 100 mm/s for safety purposes, comment alignment MarlinFirmware#20615

qwewer0 reviewed Jan 15, 2021

View reviewed changes

Roxy-3D merged commit 14567f3 into MarlinFirmware:bugfix-2.0.x Jan 23, 2021

qwewer0 mentioned this pull request Jan 23, 2021

Small cosmetic changes #20859

Merged

Roxy-3D added a commit that referenced this pull request Jan 24, 2021

Revert "Adding custom move feedrate for G26 (#20729)"

f3b5e66

This reverts commit 14567f3.

Roxy-3D mentioned this pull request Jan 24, 2021

Revert "Adding custom move feedrate for G26" #20870

Merged

Roxy-3D added a commit that referenced this pull request Jan 24, 2021

Revert "Adding custom move feedrate for G26 (#20729)" (#20870)

8f7bac4

This reverts commit 14567f3.

ScrewThisBanana mentioned this pull request Jan 25, 2021

Adding custom move feedrate for G26 Travel moves, Original #20729 #20879

Merged

kpishere pushed a commit to kpishere/Marlin that referenced this pull request Feb 19, 2021

Revert "Adding custom move feedrate for G26 (MarlinFirmware#20729)" (M…

6c5a392

…arlinFirmware#20870) This reverts commit 14567f3.

thisiskeithb added the C: Motion label Feb 25, 2021

zillarob pushed a commit to zillarob/Marlin that referenced this pull request Feb 25, 2021

Revert "Adding custom move feedrate for G26 (MarlinFirmware#20729)" (M…

fa34d17

…arlinFirmware#20870) This reverts commit 14567f3.

W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021

Revert "Adding custom move feedrate for G26 (MarlinFirmware#20729)" (M…

11bc2c3

…arlinFirmware#20870) This reverts commit 14567f3.

thinkyhead pushed a commit that referenced this pull request Apr 30, 2021

Revert "Adding custom move feedrate for G26 (#20729)" (#20870)

17a4ef6

This reverts commit 14567f3.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding custom move feedrate for G26 #20729

Adding custom move feedrate for G26 #20729

ScrewThisBanana commented Jan 9, 2021

qwewer0 commented Jan 9, 2021 •

edited

Loading

qwewer0 commented Jan 10, 2021

ScrewThisBanana commented Jan 10, 2021

ScrewThisBanana commented Jan 15, 2021 •

edited

Loading

qwewer0 Jan 15, 2021 •

edited

Loading

ScrewThisBanana Jan 25, 2021

qwewer0 Jan 25, 2021

Roxy-3D commented Jan 23, 2021

Roxy-3D commented Jan 24, 2021 •

edited

Loading

ScrewThisBanana commented Jan 24, 2021

Roxy-3D commented Jan 24, 2021

ScrewThisBanana commented Jan 25, 2021 •

edited

Loading

qwewer0 commented Jan 25, 2021

Adding custom move feedrate for G26 #20729

Adding custom move feedrate for G26 #20729

Conversation

ScrewThisBanana commented Jan 9, 2021

Requirements

Description

Benefits

Configurations

Related Issues

qwewer0 commented Jan 9, 2021 • edited Loading

qwewer0 commented Jan 10, 2021

ScrewThisBanana commented Jan 10, 2021

ScrewThisBanana commented Jan 15, 2021 • edited Loading

qwewer0 Jan 15, 2021 • edited Loading

Choose a reason for hiding this comment

ScrewThisBanana Jan 25, 2021

Choose a reason for hiding this comment

qwewer0 Jan 25, 2021

Choose a reason for hiding this comment

Roxy-3D commented Jan 23, 2021

Roxy-3D commented Jan 24, 2021 • edited Loading

ScrewThisBanana commented Jan 24, 2021

Roxy-3D commented Jan 24, 2021

ScrewThisBanana commented Jan 25, 2021 • edited Loading

qwewer0 commented Jan 25, 2021

qwewer0 commented Jan 9, 2021 •

edited

Loading

ScrewThisBanana commented Jan 15, 2021 •

edited

Loading

qwewer0 Jan 15, 2021 •

edited

Loading

Roxy-3D commented Jan 24, 2021 •

edited

Loading

ScrewThisBanana commented Jan 25, 2021 •

edited

Loading