Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LiquidCrystal CI failures #20873

Conversation

sjasonsmith
Copy link
Contributor

Description

Fix issues including the LiquidCrystal dependency.

  1. Add missing @ in the LPC section
  2. Disambiguate the two LiquidCrystal libraries, which share the same name.

Note that bitbucket-fmalpartida is no longer hosted in BitBucket, and the repo links in the PIO repository is stale. The new source location is in GitHub. It doesn't seem to have any new improvements checked in beyond forking from the BitBucket repo, so there is no compelling reason to point to it directly.
https://github.com/fmalpartida/New-LiquidCrystal

Requirements

N/A

Benefits

Fixes LPC builds. Improves ability to understand the source code.

Configurations

N/A

Related Issues

N/A

@sjasonsmith sjasonsmith changed the title Disambiguate LiquidCrystal names Fix LiquidCrystal CI failures Jan 24, 2021
@sjasonsmith sjasonsmith merged commit ea8d682 into MarlinFirmware:bugfix-2.0.x Jan 24, 2021
@thinkyhead
Copy link
Member

Ah, right! Lack of detail in PlatformIO lib_deps documentation threw me off there. Following up with 727bf7d.

TyMi pushed a commit to TyMi/Marlin that referenced this pull request Jan 25, 2021
…_bugfix

* commit '876c2586b9146dd123af4c7b21138b8239ef5d39': (116 commits)
  Clean up MMU2 code (MarlinFirmware#20794)
  Init KILL, SUICIDE, PSU earlier (MarlinFirmware#20810)
  "Move … code" followup (MarlinFirmware#20869)
  Apply SEC_TO_MS and other fixes
  Reformat abortSDPrinting
  Fix sign warning (MarlinFirmware#20872)
  Cosmetic changes (2) (MarlinFirmware#20876)
  "Move … code" followup (MarlinFirmware#20868)
  "Move … code" followup (MarlinFirmware#20874)
  Graphical TFT fixes, cleanup (MarlinFirmware#20861)
  🧻 Cosmetic changes (MarlinFirmware#20859)
  🛠Fix deps script version regex
  Fix Ender 3 V2 DWIN manual move (MarlinFirmware#20837)
  [cron] Bump distribution date (2021-01-25)
  Fix LiquidCrystal CI failures (MarlinFirmware#20873)
  Revert "Adding custom move feedrate for G26 (MarlinFirmware#20729)" (MarlinFirmware#20870)
  MeatPack serial encoding (MarlinFirmware#20802)
  [cron] Bump distribution date (2021-01-24)
  lcd_put_wchar_max for COLOR_UI (MarlinFirmware#20838)
  Adding custom move feedrate for G26 (MarlinFirmware#20729)
  ...

# Conflicts:
#	Marlin/Configuration.h
#	Marlin/Configuration_adv.h
kpishere pushed a commit to kpishere/Marlin that referenced this pull request Feb 19, 2021
Fix incorrect dependency syntax for LPC.
Disambiguate LiquidCrystal library names.
W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021
Fix incorrect dependency syntax for LPC.
Disambiguate LiquidCrystal library names.
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Apr 29, 2021
Fix incorrect dependency syntax for LPC.
Disambiguate LiquidCrystal library names.
thinkyhead pushed a commit that referenced this pull request Apr 30, 2021
Fix incorrect dependency syntax for LPC.
Disambiguate LiquidCrystal library names.
@sjasonsmith sjasonsmith deleted the PR/Ambiguous_LiquidCrystal_Libs branch April 21, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants