Add meatpack serial packing #20802
Merged
Add meatpack serial packing #20802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellensp
added
C: Serial Comms
Needs: Testing
thinkyhead
added a commit
to MarlinFirmware/Configurations
that referenced
this pull request
Jan 19, 2021
thinkyhead
added a commit
to MarlinFirmware/Configurations
that referenced
this pull request
Jan 19, 2021
nasseralmohr3600
approved these changes
Jan 19, 2021
|
I've been reading the packing code and it seems to be pretty simplified. From what I can gather this is the whole format that the plugin's packing script produces:
That should pack most commands down very well, except maybe the occasional The unpacking code looks perfectly good to me when I run it in my head. I have an OctoPrint setup and can give it a try soon. I guess it doesn't make too much sense to worry about implementing it for SD printing, but that wouldn't be too hard to add if someone wants it. |
|
next version strips white space from G0-9 ie all low gcodes.. |
added 2 commits
January 23, 2021 20:30
|
Now with support for space removal. NB needs re tested. When this was tried on prusa firmware eg G1 X40 Y20 E12 became G1X40Y20E12 and Y was incorrectly interpreted as Y2012 (ie 20 to the power of 12) . |
Haha. Marlin knows to replace the E before interpreting the number. |
|
Thanks for migrating, integrating, and merging. |
TyMi
pushed a commit
to TyMi/Marlin
that referenced
this pull request
Jan 25, 2021
…_bugfix * commit '876c2586b9146dd123af4c7b21138b8239ef5d39': (116 commits) Clean up MMU2 code (MarlinFirmware#20794) Init KILL, SUICIDE, PSU earlier (MarlinFirmware#20810) "Move … code" followup (MarlinFirmware#20869) Apply SEC_TO_MS and other fixes Reformat abortSDPrinting Fix sign warning (MarlinFirmware#20872) Cosmetic changes (2) (MarlinFirmware#20876) "Move … code" followup (MarlinFirmware#20868) "Move … code" followup (MarlinFirmware#20874) Graphical TFT fixes, cleanup (MarlinFirmware#20861) 🧻 Cosmetic changes (MarlinFirmware#20859) 🛠Fix deps script version regex Fix Ender 3 V2 DWIN manual move (MarlinFirmware#20837) [cron] Bump distribution date (2021-01-25) Fix LiquidCrystal CI failures (MarlinFirmware#20873) Revert "Adding custom move feedrate for G26 (MarlinFirmware#20729)" (MarlinFirmware#20870) MeatPack serial encoding (MarlinFirmware#20802) [cron] Bump distribution date (2021-01-24) lcd_put_wchar_max for COLOR_UI (MarlinFirmware#20838) Adding custom move feedrate for G26 (MarlinFirmware#20729) ... # Conflicts: # Marlin/Configuration.h # Marlin/Configuration_adv.h
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
zillarob
pushed a commit
to zillarob/Marlin
that referenced
this pull request
Feb 25, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead
added a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 29, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead
added a commit
that referenced
this pull request
Apr 30, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick attempt at adding meatpack serial packing to marlin2. Concise Diff
Space removal added
I don't have a way to test this at the moment.
Requirements
#define MEATPACK and something to pack the data at the sending end. Currently only the octoprint plugin OctoPrint-MeatPack
Benefits
Faster data rate for serial communications, particularly useful for UART based serial
Related Issues
#20768