-
-
Notifications
You must be signed in to change notification settings - Fork 256
Release/546.0.0 #6572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/546.0.0 #6572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Peer Dependency Version Mismatch
The account-tree-controller package's peerDependency for @metamask/multichain-account-service is ^0.7.0. This range doesn't include version 0.8.0, which is now being used, leading to peer dependency conflicts for consumers.
packages/account-tree-controller/package.json#L72-L85
core/packages/account-tree-controller/package.json
Lines 72 to 85 in 8e365d3
| "typedoc": "^0.24.8", | |
| "typedoc-plugin-missing-exports": "^2.0.0", | |
| "typescript": "~5.2.2", | |
| "webextension-polyfill": "^0.12.0" | |
| }, | |
| "peerDependencies": { | |
| "@metamask/account-api": "^0.12.0", | |
| "@metamask/accounts-controller": "^33.0.0", | |
| "@metamask/keyring-controller": "^23.0.0", | |
| "@metamask/multichain-account-service": "^0.7.0", | |
| "@metamask/profile-sync-controller": "^25.0.0", | |
| "@metamask/providers": "^22.0.0", | |
| "@metamask/snaps-controllers": "^14.0.0", | |
| "webextension-polyfill": "^0.10.0 || ^0.11.0 || ^0.12.0" |
packages/account-tree-controller/package.json#L63-L64
core/packages/account-tree-controller/package.json
Lines 63 to 64 in 8e365d3
| "@metamask/keyring-controller": "^23.0.0", | |
| "@metamask/multichain-account-service": "^0.8.0", |
|
^ Cursor: |
cryptodev-2s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
## Explanation Releases @metamask/signature-controller@34.0.0 ### Added - Add two new controller state metadata properties: `includeInStateLogs` and `usedInUi` ([#6473](#6473)) - **BREAKING:** Decode delegation permissions using `@metamask/gator-permissions-controller` when calling `newUnsignedTypedMessage`, adds `@metamask/gator-permissions-controller` as a peer dependency. ([#6619](#6619)) ### Changed - Bump `@metamask/controller-utils` from `^11.12.0` to `^11.14.0` ([#6620](#6620), [#6629](#6629)) - Bump `@metamask/base-controller` from `^8.1.0` to `^8.4.0` ([#6355](#6355), [#6465](#6465), [#6632](#6632)) - Bump `@metamask/utils` from `^11.4.2` to `^11.8.0` ([#6588](#6588)) - Bump `@metamask/network-controller` from `^24.1.0` to `^24.2.0` ([#6678](#6678)) - Bump `@metamask/keyring-controller` from `^23.0.0` to `^23.1.0` ([#6590](#6590)) - Bump `@metamask/accounts-controller` from `^33.0.0` to `^33.1.0` ([#6572](#6572))
accounts-controllerto fix events ordering for theaccount-tree-controllermultichain-account-servicefor the wallet status support