Skip to content

Conversation

@ccharly
Copy link
Contributor

@ccharly ccharly commented Sep 11, 2025

  • Minor release for the accounts-controller to fix events ordering for the account-tree-controller
  • Minor release for the multichain-account-service for the wallet status support

@ccharly ccharly marked this pull request as ready for review September 11, 2025 15:58
@ccharly ccharly requested review from a team as code owners September 11, 2025 15:58
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Peer Dependency Version Mismatch

The account-tree-controller package's peerDependency for @metamask/multichain-account-service is ^0.7.0. This range doesn't include version 0.8.0, which is now being used, leading to peer dependency conflicts for consumers.

packages/account-tree-controller/package.json#L72-L85

"typedoc": "^0.24.8",
"typedoc-plugin-missing-exports": "^2.0.0",
"typescript": "~5.2.2",
"webextension-polyfill": "^0.12.0"
},
"peerDependencies": {
"@metamask/account-api": "^0.12.0",
"@metamask/accounts-controller": "^33.0.0",
"@metamask/keyring-controller": "^23.0.0",
"@metamask/multichain-account-service": "^0.7.0",
"@metamask/profile-sync-controller": "^25.0.0",
"@metamask/providers": "^22.0.0",
"@metamask/snaps-controllers": "^14.0.0",
"webextension-polyfill": "^0.10.0 || ^0.11.0 || ^0.12.0"

packages/account-tree-controller/package.json#L63-L64

"@metamask/keyring-controller": "^23.0.0",
"@metamask/multichain-account-service": "^0.8.0",

Fix in Cursor Fix in Web


@ccharly
Copy link
Contributor Author

ccharly commented Sep 11, 2025

^ Cursor:
That's ok, I do plan to make this update right after with another PR that actually need the multichain-account-service to be release.

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ccharly ccharly enabled auto-merge (squash) September 11, 2025 16:17
@ccharly ccharly merged commit 08d2675 into main Sep 11, 2025
247 of 248 checks passed
@ccharly ccharly deleted the release/546.0.0 branch September 11, 2025 16:17
This was referenced Sep 23, 2025
jeffsmale90 added a commit that referenced this pull request Sep 24, 2025
## Explanation

Releases @metamask/signature-controller@34.0.0

### Added

- Add two new controller state metadata properties: `includeInStateLogs`
and `usedInUi` ([#6473](#6473))
- **BREAKING:** Decode delegation permissions using
`@metamask/gator-permissions-controller` when calling
`newUnsignedTypedMessage`, adds `@metamask/gator-permissions-controller`
as a peer dependency.
([#6619](#6619))

### Changed

- Bump `@metamask/controller-utils` from `^11.12.0` to `^11.14.0`
([#6620](#6620),
[#6629](#6629))
- Bump `@metamask/base-controller` from `^8.1.0` to `^8.4.0`
([#6355](#6355),
[#6465](#6465),
[#6632](#6632))
- Bump `@metamask/utils` from `^11.4.2` to `^11.8.0`
([#6588](#6588))
- Bump `@metamask/network-controller` from `^24.1.0` to `^24.2.0`
([#6678](#6678))
- Bump `@metamask/keyring-controller` from `^23.0.0` to `^23.1.0`
([#6590](#6590))
- Bump `@metamask/accounts-controller` from `^33.0.0` to `^33.1.0`
([#6572](#6572))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants