Skip to content

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Sep 16, 2025

Explanation

Minor release of @metamask/messenger and @metamask/base-controller

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Gudahtt Gudahtt marked this pull request as ready for review September 16, 2025 19:54
@Gudahtt Gudahtt requested review from a team as code owners September 16, 2025 19:54
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 33dd8d6 into main Sep 16, 2025
255 checks passed
@Gudahtt Gudahtt deleted the release/558.0.0 branch September 16, 2025 20:19
jeffsmale90 added a commit that referenced this pull request Sep 24, 2025
## Explanation

Releases @metamask/signature-controller@34.0.0

### Added

- Add two new controller state metadata properties: `includeInStateLogs`
and `usedInUi` ([#6473](#6473))
- **BREAKING:** Decode delegation permissions using
`@metamask/gator-permissions-controller` when calling
`newUnsignedTypedMessage`, adds `@metamask/gator-permissions-controller`
as a peer dependency.
([#6619](#6619))

### Changed

- Bump `@metamask/controller-utils` from `^11.12.0` to `^11.14.0`
([#6620](#6620),
[#6629](#6629))
- Bump `@metamask/base-controller` from `^8.1.0` to `^8.4.0`
([#6355](#6355),
[#6465](#6465),
[#6632](#6632))
- Bump `@metamask/utils` from `^11.4.2` to `^11.8.0`
([#6588](#6588))
- Bump `@metamask/network-controller` from `^24.1.0` to `^24.2.0`
([#6678](#6678))
- Bump `@metamask/keyring-controller` from `^23.0.0` to `^23.1.0`
([#6590](#6590))
- Bump `@metamask/accounts-controller` from `^33.0.0` to `^33.1.0`
([#6572](#6572))
@AugmentedMode AugmentedMode mentioned this pull request Sep 24, 2025
4 tasks
mathieuartu added a commit that referenced this pull request Sep 29, 2025
## Explanation

Release for `@metamask/profile-sync-controller` &
`@metamask/multichain-account-service`.

```md
## [25.1.0]

### Changed

- Use deferred promises for encryption/decryption KDF operations ([#6736](#6736))
  - That will prevent duplicate KDF operations from being computed if one with the same options is already in progress.
  - For operations that already completed, we use the already existing cache.
- Bump `@metamask/utils` from `^11.8.0` to `^11.8.1` ([#6708](#6708))
- Bump `@metamask/keyring-api` from `^20.1.0` to `^21.0.0` ([#6560](#6560))
- Bump `@metamask/keyring-internal-api` from `^8.1.0` to `^9.0.0` ([#6560](#6560))
- Strip `srpSessionData.token.accessToken` from state logs ([#6553](#6553))
  - We haven't started using the `includeInStateLogs` metadata yet in clients, so this will have no functional impact. This change brings this metadata into alignment with the hard-coded state log generation performed by clients.today.
- Add dependency on `@metamask/utils` ([#6553](#6553))
- Bump `@metamask/base-controller` from `^8.3.0` to `^8.4.0` ([#6632](#6632))
```

## References

<!--
Are there any issues that this pull request is tied to?
Are there other links that reviewers should consult to understand these
changes better?
Are there client or consumer pull requests to adopt any breaking
changes?

For example:

* Fixes #12345
* Related to #67890
-->

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs),
highlighting breaking changes as necessary
- [ ] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Releases core 589.0.0, publishing @metamask/profile-sync-controller
25.1.0 and @metamask/multichain-account-service 1.3.0, and bumps
dependent packages and changelogs.
> 
> - **Release**: `@metamask/core-monorepo` to `589.0.0`.
> - **Packages**:
>   - `@metamask/profile-sync-controller@25.1.0`
> - Use deferred promises for KDF operations; update deps and strip
`srpSessionData.token.accessToken` from state logs.
>   - `@metamask/multichain-account-service@1.3.0`
>     - Add `{Btc, Trx}AccountProvider`; update compare links.
> - **Deps Bumped**:
> - Update references to `@metamask/profile-sync-controller` to
`^25.1.0` in `account-tree-controller`,
`notification-services-controller`, `subscription-controller`, and
lockfile.
> - Update references to `@metamask/multichain-account-service` to
`^1.3.0` in `assets-controllers`, `account-tree-controller`, and
lockfile.
> - **Changelogs**:
> - Add Unreleased note for `assets-controllers` reflecting
`multichain-account-service` bump.
>   - Add `1.3.0` section and links in `multichain-account-service`.
>   - Add `25.1.0` section and links in `profile-sync-controller`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
88351ca. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
github-merge-queue bot pushed a commit to MetaMask/metamask-mobile that referenced this pull request Oct 21, 2025
## **Description**

Updates the dependency on @metamask/signature-controller to 34.0.0

This version bump introduces a dependency on
@metamask/gator-permissions-controller via
`GatorPermissionsControllerDecodePermissionFromPermissionContextForOriginAction`
which has been added to signature-controller-messenger.

## **Changelog**

From SignatureController
https://github.com/MetaMask/core/blob/main/packages/signature-controller/CHANGELOG.md:

### @metamask/signature-controller 34.0.0

#### Added

- Add two new controller state metadata properties: includeInStateLogs
and usedInUi (MetaMask/core#6473)
- Decode delegation permissions using
`@metamask/gator-permissions-controller` when calling
`newUnsignedTypedMessage`
([#6619](MetaMask/core#6619))

#### Changed

- Bump @metamask/controller-utils from ^11.12.0 to ^11.14.0
(MetaMask/core#6620,
MetaMask/core#6629)
- Bump @metamask/base-controller from ^8.1.0 to ^8.4.0
(MetaMask/core#6355,
MetaMask/core#6465,
MetaMask/core#6632)
- Bump @metamask/utils from ^11.4.2 to ^11.8.0
(MetaMask/core#6588)

### @metamask/signature-controller 33.0.0

#### Changed

- BREAKING: Bump peer dependency @metamask/accounts-controller from
^32.0.0 to ^33.0.0 (MetaMask/core#6345)
- BREAKING: Bump peer dependency @metamask/keyring-controller from
^22.0.0 to ^23.0.0 (MetaMask/core#6345)
- Bump @metamask/base-controller from ^8.0.1 to ^8.1.0
(MetaMask/core#6284)
- Bump @metamask/controller-utils from ^11.11.0 to ^11.12.0
(MetaMask/core#6303)

CHANGELOG entry: null

## **Screenshots/Recordings**

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Upgrade @metamask/signature-controller to ^34 and allow
GatorPermissionsController decode action in the signature controller
messenger.
> 
> - **Dependencies**:
>   - Bump `@metamask/signature-controller` to `^34.0.0`.
> - **Engine**:
> -
**`app/core/Engine/messengers/signature-controller-messenger/signature-controller-messenger.ts`**:
> - Add
`GatorPermissionsControllerDecodePermissionFromPermissionContextForOriginAction`
and allow
`GatorPermissionsController:decodePermissionFromPermissionContextForOrigin`
in `allowedActions`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
657705e. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants