Skip to content

Conversation

@Julink-eth
Copy link
Contributor

@Julink-eth Julink-eth commented Sep 16, 2025

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Julink-eth Julink-eth marked this pull request as ready for review September 16, 2025 14:18
@Julink-eth Julink-eth requested review from a team as code owners September 16, 2025 14:19
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit e2521d7 into main Sep 16, 2025
239 checks passed
@Gudahtt Gudahtt deleted the release/556.0.0 branch September 16, 2025 15:20
@ffmcgee725 ffmcgee725 mentioned this pull request Sep 23, 2025
4 tasks
ffmcgee725 added a commit that referenced this pull request Sep 23, 2025
## Explanation

Release for `@metamask/multichain-api-middleware`

- Add partial permission revoke into `wallet_revokeSession`
([#6668](#6668))
- Bump `@metamask/chain-agnostic-permission` from `1.0.0` to `1.1.1`
([#6241](#6241),
[#6345](#6241))
- Bump `@metamask/controller-utils` from `^11.10.0` to `^11.14.0`
([#6069](#6069),
[#6303](#6303),
[#6620](#6620),
[#6629](#6629))
- Bump `@metamask/network-controller` from `^24.0.0` to `^24.2.0`
([#6148](#6148),
[#6303](#6303),
[#6678](#6678))
- Bump `@metamask/utils` from `^11.2.0` to `^11.4.2`
([#6054](#6054))
- Bump `@metamask/utils` from `^11.4.2` to `^11.8.0`
([#6588](#6588))
- Bump `@metamask/json-rpc-engine` from `^10.0.3` to `^10.1.0`
([#6678](#6678))

<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?
* Are there any changes whose purpose might not obvious to those
unfamiliar with the domain?
* If your primary goal was to update one package but you found you had
to update another one along the way, why did you do so?
* If you had to upgrade a dependency, why did you do so?
-->

## References

<!--
Are there any issues that this pull request is tied to?
Are there other links that reviewers should consult to understand these
changes better?
Are there client or consumer pull requests to adopt any breaking
changes?

For example:

* Fixes #12345
* Related to #67890
-->

* Fixes https://consensyssoftware.atlassian.net/browse/WAPI-728

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs),
highlighting breaking changes as necessary
- [x] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes
@jeffsmale90 jeffsmale90 mentioned this pull request Sep 23, 2025
jeffsmale90 added a commit that referenced this pull request Sep 24, 2025
## Explanation

Releases @metamask/signature-controller@34.0.0

### Added

- Add two new controller state metadata properties: `includeInStateLogs`
and `usedInUi` ([#6473](#6473))
- **BREAKING:** Decode delegation permissions using
`@metamask/gator-permissions-controller` when calling
`newUnsignedTypedMessage`, adds `@metamask/gator-permissions-controller`
as a peer dependency.
([#6619](#6619))

### Changed

- Bump `@metamask/controller-utils` from `^11.12.0` to `^11.14.0`
([#6620](#6620),
[#6629](#6629))
- Bump `@metamask/base-controller` from `^8.1.0` to `^8.4.0`
([#6355](#6355),
[#6465](#6465),
[#6632](#6632))
- Bump `@metamask/utils` from `^11.4.2` to `^11.8.0`
([#6588](#6588))
- Bump `@metamask/network-controller` from `^24.1.0` to `^24.2.0`
([#6678](#6678))
- Bump `@metamask/keyring-controller` from `^23.0.0` to `^23.1.0`
([#6590](#6590))
- Bump `@metamask/accounts-controller` from `^33.0.0` to `^33.1.0`
([#6572](#6572))
@AugmentedMode AugmentedMode mentioned this pull request Sep 24, 2025
4 tasks
github-merge-queue bot pushed a commit to MetaMask/metamask-mobile that referenced this pull request Oct 21, 2025
## **Description**

Updates the dependency on @metamask/signature-controller to 34.0.0

This version bump introduces a dependency on
@metamask/gator-permissions-controller via
`GatorPermissionsControllerDecodePermissionFromPermissionContextForOriginAction`
which has been added to signature-controller-messenger.

## **Changelog**

From SignatureController
https://github.com/MetaMask/core/blob/main/packages/signature-controller/CHANGELOG.md:

### @metamask/signature-controller 34.0.0

#### Added

- Add two new controller state metadata properties: includeInStateLogs
and usedInUi (MetaMask/core#6473)
- Decode delegation permissions using
`@metamask/gator-permissions-controller` when calling
`newUnsignedTypedMessage`
([#6619](MetaMask/core#6619))

#### Changed

- Bump @metamask/controller-utils from ^11.12.0 to ^11.14.0
(MetaMask/core#6620,
MetaMask/core#6629)
- Bump @metamask/base-controller from ^8.1.0 to ^8.4.0
(MetaMask/core#6355,
MetaMask/core#6465,
MetaMask/core#6632)
- Bump @metamask/utils from ^11.4.2 to ^11.8.0
(MetaMask/core#6588)

### @metamask/signature-controller 33.0.0

#### Changed

- BREAKING: Bump peer dependency @metamask/accounts-controller from
^32.0.0 to ^33.0.0 (MetaMask/core#6345)
- BREAKING: Bump peer dependency @metamask/keyring-controller from
^22.0.0 to ^23.0.0 (MetaMask/core#6345)
- Bump @metamask/base-controller from ^8.0.1 to ^8.1.0
(MetaMask/core#6284)
- Bump @metamask/controller-utils from ^11.11.0 to ^11.12.0
(MetaMask/core#6303)

CHANGELOG entry: null

## **Screenshots/Recordings**

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Upgrade @metamask/signature-controller to ^34 and allow
GatorPermissionsController decode action in the signature controller
messenger.
> 
> - **Dependencies**:
>   - Bump `@metamask/signature-controller` to `^34.0.0`.
> - **Engine**:
> -
**`app/core/Engine/messengers/signature-controller-messenger/signature-controller-messenger.ts`**:
> - Add
`GatorPermissionsControllerDecodePermissionFromPermissionContextForOriginAction`
and allow
`GatorPermissionsController:decodePermissionFromPermissionContextForOrigin`
in `allowedActions`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
657705e. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants