Version v12.7.2 RC #28705

metamaskbot · 2024-11-25T20:42:13Z

📦 🚀

This reverts commit fa895e5.

This reverts commit 134d9a6.

fix: lattice sign typed signature verification error

github-actions · 2024-11-26T02:01:12Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-11-26T02:02:12Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@chainsafe/as-sha256@0.3.1	None	`0`	165 kB	dapplion
npm/@chainsafe/persistent-merkle-tree@0.4.2	None	`0`	112 kB	dapplion
npm/@chainsafe/ssz@0.9.4	None	`0`	468 kB	dapplion
npm/@scure/base@1.1.7	None	`0`	122 kB	paulmillr
npm/bitwise@2.1.0	None	`0`	120 kB	florianwendelborn
npm/case@1.6.3	None	`0`	39.1 kB	nbubna
npm/crc-32@1.2.0	None	`0`	13.3 kB	sheetjs
npm/elliptic@6.5.4	None	`+1`	160 kB	indutny
npm/eth-chainlist@0.0.498	None	`0`	1.13 MB	zanechua
npm/eth-eip712-util-browser@0.0.3	None	`0`	33.9 kB	asmiller1989
npm/exit-on-epipe@1.0.1	None	`0`	5 kB	sheetjs
npm/gridplus-sdk@2.5.1	environment, network	`+2`	789 kB	asmiller1989
npm/printj@1.1.2	None	`0`	113 kB	sheetjs

🚮 Removed packages: npm/@scure/base@1.1.9, npm/@sovpro/delimited-stream@1.1.0, npm/bitwise@2.2.1, npm/borc@3.0.0, npm/crc-32@1.2.2, npm/elliptic@6.5.7, npm/eth-chainlist@0.0.519, npm/gridplus-sdk@2.7.1, npm/iso-url@1.2.1, npm/json-text-sequence@0.3.0

View full report↗︎

socket-security · 2024-11-26T02:02:14Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/elliptic@6.5.4, npm/@noble/secp256k1@1.6.3, npm/exit-on-epipe@1.0.1, npm/crc-32@1.2.0, npm/printj@1.1.2, npm/ethereum-cryptography@1.1.2, npm/@noble/hashes@1.1.2, npm/@scure/bip32@1.1.0, npm/@scure/bip39@1.1.0, npm/@chainsafe/as-sha256@0.3.1, npm/@chainsafe/persistent-merkle-tree@0.4.2, npm/@chainsafe/ssz@0.9.4, npm/case@1.6.3, npm/bitwise@2.1.0, npm/@ethereumjs/tx@4.1.1, npm/@ethereumjs/common@3.1.1, npm/eth-eip712-util-browser@0.0.3, npm/gridplus-sdk@2.5.1, npm/@scure/base@1.1.7, npm/eth-chainlist@0.0.498

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

…id exceeding our quota (#28573) ## **Description** - Divide by 2 our sentry trace sample rate to avoid exceeding our quota ## **Related issues** Fixes: None ## **Manual testing steps** - None ## **Screenshots/Recordings** - None ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: Harika <153644847+hjetpoluru@users.noreply.github.com>

Cherry pick 62430fb (#28573) to v12.7.2

metamaskbot · 2024-11-26T02:53:25Z

Builds ready [c4e1d93]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1947 ± 62 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	294	2185	1782	486	233
		domContentLoaded	1680	2174	1911	128	62
		load	1684	2187	1947	130	62
		domInteractive	16	259	59	59	28
		backgroundConnect	6	83	35	22	11
		firstReactRender	49	215	89	35	17
		getState	5	87	29	26	12
		initialActions	0	1	0	0	0
		loadScripts	1210	1667	1404	110	53
		setupStore	12	105	38	27	13
		uiStartup	1883	2704	2179	181	87

danjm · 2024-11-26T03:47:41Z

@SocketSecurity ignore-all

This returns these dependencies to the state they were in on v12.6.2, and these issues are fixed in develop

metamaskbot · 2024-11-26T04:08:17Z

Builds ready [c4e1d93]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1780 ± 55 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1581	2155	1787	112	54
		domContentLoaded	1565	2065	1747	105	50
		load	1582	2157	1780	115	55
		domInteractive	24	95	49	19	9
		backgroundConnect	11	89	34	24	11
		firstReactRender	44	110	82	21	10
		getState	4	60	15	15	7
		initialActions	0	1	0	0	0
		loadScripts	1146	1572	1295	92	44
		setupStore	10	61	25	18	8
		uiStartup	1750	2447	1968	135	65

Version v12.7.2

ccc35cc

github-actions bot added the team-bot Bot team (for MetaMask Bot) label Nov 25, 2024

danjm added 3 commits November 25, 2024 21:07

Revert "chore: Bump gridplus-sdk to 2.7.1 (#28008)"

6777ad7

This reverts commit fa895e5.

Revert "fix(deps): gridplus-sdk@2.5.1->~2.6.0 (#27973)"

02ff1ab

This reverts commit 134d9a6.

Merge pull request #28694 from MetaMask/fix/lattice-sign-typed-error

c40c1a5

fix: lattice sign typed signature verification error

gauthierpetetin and others added 3 commits November 25, 2024 22:43

Merge pull request #28711 from MetaMask/cherry-pick-62430fb-12.7.2

8724b63

Cherry pick 62430fb (#28573) to v12.7.2

Update changelog for v12.7.2 (#28712)

c4e1d93

danjm marked this pull request as ready for review November 26, 2024 03:55

danjm requested review from a team as code owners November 26, 2024 03:55

danjm approved these changes Nov 26, 2024

View reviewed changes

danjm merged commit 040cb8d into master Nov 26, 2024
80 checks passed

danjm deleted the Version-v12.7.2 branch November 26, 2024 13:28

github-actions bot locked and limited conversation to collaborators Nov 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Version v12.7.2 RC #28705

Version v12.7.2 RC #28705

metamaskbot commented Nov 25, 2024

github-actions bot commented Nov 26, 2024

socket-security bot commented Nov 26, 2024 •

edited

Loading

socket-security bot commented Nov 26, 2024 •

edited

Loading

metamaskbot commented Nov 26, 2024

danjm commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

Version v12.7.2 RC #28705

Version v12.7.2 RC #28705

Conversation

metamaskbot commented Nov 25, 2024

github-actions bot commented Nov 26, 2024

socket-security bot commented Nov 26, 2024 • edited Loading

socket-security bot commented Nov 26, 2024 • edited Loading

Next steps

metamaskbot commented Nov 26, 2024

danjm commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

socket-security bot commented Nov 26, 2024 •

edited

Loading

socket-security bot commented Nov 26, 2024 •

edited

Loading