fix(premature close): gracefully end extension stream muxes to prevent "Premature close" errors #37400
+593
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [d5f5e65]
UI Startup Metrics (1269 ± 99 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gauthierpetetin
force-pushed
the
premature-close-error
branch
from
d5f5e65 to
64e70d8
Compare
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [64e70d8]
UI Startup Metrics (1280 ± 71 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gauthierpetetin
force-pushed
the
premature-close-error
branch
from
64e70d8 to
4b6c51f
Compare
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [4b6c51f]
UI Startup Metrics (1156 ± 76 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…ation to prevent pipeline errors
gauthierpetetin
force-pushed
the
premature-close-error
branch
from
4b6c51f to
e72ec5e
Compare
gauthierpetetin
changed the title
Collaborator
Builds ready [e72ec5e]
UI Startup Metrics (1257 ± 78 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
approved these changes
Nov 3, 2025
Contributor
|
LGTM !! |
itsyoboieltr
approved these changes
Nov 7, 2025
github-project-automation
bot
moved this from Needs dev review
to Review finalised - Ready to be merged
in PR review queue
github-project-automation
bot
moved this from Review finalised - Ready to be merged
to Merged, Closed or Archived
in PR review queue
metamaskbot
added
the
release-13.10.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an AI-generated fix aiming to fix the #1 error in Sentry (3.8M occurrences/month) by adding graceful shutdown handlers to extension context streams, preventing "ERR_STREAM_PREMATURE_CLOSE" errors.
The error was initially discussed in this Slack thread.
Disclaimer
Since we haven't found a reliable way to manually reproduce these "Premature close" errors, there's no "before/after proof" that this PR fixes it.
Problem
When underlying transport streams (e.g.,
WindowPostMessageStream,ExtensionPortStream) close or end abruptly—during page navigation, tab closure, or extension disconnection—theObjectMultiplexinstances in extension context do not gracefully shut down. This results in "Premature close" errors being thrown by the stream pipeline.Solution
Added graceful shutdown handlers to extension context streams that:
once('close')andonce('end')listeners to underlying transport streams!destroyed && !writableEnded) and callmux.end()before pipeline error detection kicks inKey Design Decision: Page Context vs Extension Context
Why handlers are ONLY in extension context streams:
inpage.jsprovider-stream.tsphishing-stream.tscookie-handler-stream.tsThis approach mirrors the solution in #33470 for CAIP streams.
Changelog
CHANGELOG entry: Fixed "Premature close" stream errors in extension context by adding graceful shutdown handlers
Related issues
Fixes: #26337
Fixes: #35241
Fixes: #21078
Manual testing steps
(disclaimer: the error is hard to reproduce, even with these manual testing steps)
chrome://extensions→ MetaMask → "service worker"chrome-extension://{extension-id}/home.html#link?u=/buyand verify it redirects cleanly without errorsExpected: Clean shutdowns with no "Premature close" errors in console
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Add graceful shutdown handlers to extension-context multiplexers for provider, phishing, and cookie-handler streams, plus tests; clarify no handlers in page-context in inpage.
close/endto avoidERR_STREAM_PREMATURE_CLOSEin:app/scripts/streams/provider-stream.ts(pageMux,extensionMux)app/scripts/streams/phishing-stream.ts(phishingPageMux,phishingExtMux)app/scripts/streams/cookie-handler-stream.ts(cookieHandlerPageMux,cookieHandlerMux)logStreamDisconnectWarningand sendingMETAMASK_STREAM_FAILUREwhere applicable.app/scripts/inpage.js: Add documentation explaining why graceful shutdown handlers are not added in page context.provider-stream.filter.test.tsphishing-stream.filter.test.tscookie-handler-stream.filter.test.tsWritten by Cursor Bugbot for commit e72ec5e. This will update automatically on new commits. Configure here.